[#36031] - [4.0] Atum alert styling
- Fixed in Code Base
- 28 Nov 2021
- Medium
- Build: 4.0-dev
- # 36031
- Diff
- brianteeman:atem-logical-alert
User tests: Successful: Unsuccessful:
This is a replacement to part of the merged PR #30294
It does exactly the same thing but by using css logical properties we avoid the need to maintain both an LTR and an RTL version
There is no visual change.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36031.
@Shubhamverma2796 @khu5h1 You have tested with an RTL language, too?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36031.
@infograf768 I'm a bit confused about your positive test. In the other PR #36040 you pointed out that inset-inline-end is not supported by Safari 14 and lower, and this PR uses the same logical property inset-inline-end.
@richard67 I have tested with an RTL language on Chrome and Firefox browsers.
| Labels |
Added:
NPM Resource Changed
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36031.
| Status | Pending | ⇒ | Ready to Commit |
Grr. RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36031.
Setting RLDQ label so release leads can decide about usage of inset-inline regarding our browser support policy.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36031.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-28 17:16:36 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thanks!
Thanks
I have tested this item✅ successfully on 70a040f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36031.