Joomla! Issue Tracker | Joomla! CMS #36015 - ComponentAdapter Manifest Namespace-Tag not stored

No Code Attached Yet bug

New
Medium
Build: 4.0-dev
# 36015

JProof
11 Nov 2021

only collecting some informations

The "public function refreshManifestCache()" is a database store only method

The following line can never be true

joomla-cms/libraries/src/Installer/Adapter/ComponentAdapter.php

Line 1479 in a94decc

if (isset($manifest_details['namespace']))

because of from :

joomla-cms/libraries/src/Installer/Installer.php

Line 2288 in a94decc

$data = array();

joomla-cms/libraries/src/Installer/Installer.php

Line 2319 in a94decc

Question is:
write namespace to database ? ( -1 )
then the $data['namespace'] must be set with path="" if exist
or
remove the

joomla-cms/libraries/src/Installer/Adapter/ComponentAdapter.php

Line 1479 in a94decc

if (isset($manifest_details['namespace']))

checking because it is never true

JProof - open - 11 Nov 2021

joomla-cms-bot - change - 11 Nov 2021

Labels

Added: No Code Attached Yet

joomla-cms-bot - labeled - 11 Nov 2021

joomdonation - comment - 4 Dec 2022

@JProof We do not store namespace of component in database, so I would say removing the if block

joomla-cms/libraries/src/Installer/Adapter/ComponentAdapter.php

Lines 1479 to 1482 in a94decc

    
           if (isset($manifest_details['namespace'])) 
        
           { 
        
           	$this->parent->extension->namespace = $manifest_details['namespace']; 
        
           }

as you mentioned is a valid solution. Could you please make PR ?

Hackwar - change - 22 Feb 2023

Labels

Added: bug

Hackwar - labeled - 22 Feb 2023

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#36015] - ComponentAdapter Manifest Namespace-Tag not stored

Add a Comment

	if (isset($manifest_details['namespace']))
	{
	$this->parent->extension->namespace = $manifest_details['namespace'];
	}