No Code Attached Yet bug
avatar JProof
JProof
11 Nov 2021

only collecting some informations

The "public function refreshManifestCache()" is a database store only method

The following line can never be true

if (isset($manifest_details['namespace']))

because of from :


img-2021-11-12-00-18-10

Question is:
write namespace to database ? ( -1 )
then the $data['namespace'] must be set with path="" if exist
or
remove the

if (isset($manifest_details['namespace']))

checking because it is never true

avatar JProof JProof - open - 11 Nov 2021
avatar joomla-cms-bot joomla-cms-bot - change - 11 Nov 2021
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 11 Nov 2021
avatar joomdonation
joomdonation - comment - 4 Dec 2022

@JProof We do not store namespace of component in database, so I would say removing the if block

if (isset($manifest_details['namespace']))
{
$this->parent->extension->namespace = $manifest_details['namespace'];
}
as you mentioned is a valid solution. Could you please make PR ?

avatar Hackwar Hackwar - change - 22 Feb 2023
Labels Added: bug
avatar Hackwar Hackwar - labeled - 22 Feb 2023
avatar brianteeman
brianteeman - comment - 1 Oct 2026

@joomdonation is your comment still valid since #39011 (ignoring the comment that its for child templates)

avatar joomdonation
joomdonation - comment - 1 Oct 2026

@brianteeman Yes, it is still valid. These lines of code allow storing namespace of component to namespace column in #__extensions table. However, we dropped namespace column from #__extensions table few years ago, so that lines of code is useless. We could also remove these lines of code https://github.com/joomla/joomla-cms/blob/5.4-dev/libraries/src/Installer/Adapter/ComponentAdapter.php#L892-L893 , too.

Add a Comment

Login with GitHub to post a comment