This is a known issue due to some limitations from the J3 code: https://github.com/mbabker/com_empty/blob/4a199f19b2d7ab240b6092057b7edbff666818e9/com_empty/empty.xml#L18-L20

funny

Sad panda

@alikon I think that the check for the administrator in the manifest should be done much earlier and bail out without doing anything more (now it copies files, etc). So, I guess this is still a valid issue

Okay!

By the way, the <administrator><menu>... also never works on discover, perhaps that is the right time to change this "ugly" behaviours?

perhaps that is the right time to change this "ugly" behaviours?

You're welcome to contribute some code

yes for sure, @JProof please submit a pr

i've always thinked that
<administration> </administration>

was mandatory

anyway happy to be wrong ?

i've always thinked that <administration> </administration> was mandatory

That's right, it is mandatory. That said if it's missing it shouldn't produce half installed components

There's a PR that changes the order of execution so the installer will bail out without writting any files: #36014

will look at the weekend for the following "issues"

• this issue
• the <administration><menu (f**ks me of since a couple of years xD) reinstall the admin component menu items(if changed)
• and the <namespace in manifest

Goal is develop directly in joomla fast/simple components and "discover" that the component is working.

cu

@JProof you could test #36014. It doesn't solve all the issues but at least won't produce the current mess (I hope)

@dgrammatiko yes ..thanks. will look for it over the weekend.

@dgrammatiko as the <administration> is mandatory, why we throw the RuntimeException?
That makes no sense for me.

// Make sure that we have an admin element
		if (!$this->getManifest()->administration)
		{
			throw new \RuntimeException(Text::_('JLIB_INSTALLER_ERROR_COMP_INSTALL_ADMIN_ELEMENT'));
		}

as the is mandatory, why we throw the RuntimeException?

I guess it was supposed to be a fail-safe switch but it ran too late, the conditional should be an indication if the installation should proceed or not. The trhowable it's more to do with the parent code (the try/catch part)

Okay, thank you!
last question for the moment i hope

https://github.com/joomla/joomla-cms/tree/4.0-dev/tests/Unit/Libraries/Cms/Installer/Adapter
There is no unit.test for the ComponentAdapter? or i am in wrong location?

There is no unit.test for the ComponentAdapter? or i am in wrong location?

You're right, no unit tests