? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar regularlabs
regularlabs
8 Nov 2021

This PR adds events to the showing and hiding of shown elements.

So now you can trigger stuff when elements are dynamically shown or hidden, like:

document.addEventListener('joomla:showon-show', () => {
	const editor = document.querySelector('.CodeMirror');
	editor && editor.CodeMirror.refresh();
});

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar regularlabs regularlabs - open - 8 Nov 2021
avatar regularlabs regularlabs - change - 8 Nov 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Nov 2021
Category JavaScript Repository NPM Change
avatar regularlabs regularlabs - change - 8 Nov 2021
The description was changed
avatar regularlabs regularlabs - edited - 8 Nov 2021
avatar Fedik
Fedik - comment - 9 Nov 2021

Thanks, looks good now. Ready for testing.

avatar regularlabs
regularlabs - comment - 9 Nov 2021

Sucks that we have to wait at least another 3 months before we can use this in our extensions to work around issues in Joomla.
Which means I'll have to implement some kind of work-around, which defies the reason for needing this in core for me.

avatar regularlabs regularlabs - change - 9 Nov 2021
Labels Added: NPM Resource Changed ?
avatar Fedik Fedik - test_item - 12 Nov 2021 - Tested successfully
avatar Fedik
Fedik - comment - 12 Nov 2021

I have tested this item successfully on 43ff9c6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35994.

avatar Fedik
Fedik - comment - 12 Nov 2021

For test create a field with showon, and add next js somewhere:

document.addEventListener('joomla:showon-show', () => {
 alert('Show!')
});
document.addEventListener('joomla:showon-hide', () => {
 alert('Hide!')
});

You should get an alert when an element is shows and when it hides.

avatar alikon alikon - test_item - 12 Nov 2021 - Tested successfully
avatar alikon
alikon - comment - 12 Nov 2021

I have tested this item successfully on 43ff9c6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35994.

avatar alikon alikon - change - 12 Nov 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 12 Nov 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35994.

avatar regularlabs
regularlabs - comment - 13 Nov 2021

Thanks!

avatar regularlabs regularlabs - change - 13 Nov 2021
Labels Added: ?
avatar pritam825 pritam825 - test_item - 13 Nov 2021 - Tested successfully
avatar pritam825
pritam825 - comment - 13 Nov 2021

I have tested this item successfully on 37db4fa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35994.

avatar khu5h1 khu5h1 - test_item - 13 Nov 2021 - Tested successfully
avatar khu5h1
khu5h1 - comment - 13 Nov 2021

I have tested this item successfully on 37db4fa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35994.

avatar bembelimen bembelimen - change - 13 Nov 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-11-13 22:58:53
Closed_By bembelimen
avatar bembelimen bembelimen - close - 13 Nov 2021
avatar bembelimen bembelimen - merge - 13 Nov 2021
avatar bembelimen
bembelimen - comment - 13 Nov 2021

Thx

Add a Comment

Login with GitHub to post a comment