? NPM Resource Changed Pending

User tests: Successful: Unsuccessful:

avatar regularlabs
regularlabs
8 Nov 2021

This PR adds events to the showing and hiding of shown elements.

So now you can trigger stuff when elements are dynamically shown or hidden, like:

document.addEventListener('showon-show', () => {
	const editor = document.querySelector('.CodeMirror');
	editor && editor.CodeMirror.refresh();
});
avatar regularlabs regularlabs - open - 8 Nov 2021
avatar regularlabs regularlabs - change - 8 Nov 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Nov 2021
Category JavaScript Repository NPM Change
avatar regularlabs regularlabs - change - 8 Nov 2021
The description was changed
avatar regularlabs regularlabs - edited - 8 Nov 2021
avatar Fedik
Fedik - comment - 8 Nov 2021

Please trigger this events within "changed element" instead of document,

avatar regularlabs regularlabs - change - 8 Nov 2021
Labels Added: ? NPM Resource Changed
avatar regularlabs
regularlabs - comment - 8 Nov 2021

Trigger on document was a copy/paste error. Oops. Fixed now.

Regarding the syntax of the event name, there are different syntaxes used by Joomla scripts:
messages use: joomla.alert.close
subforms use: subform-row-remove and joomla:removed
menus use: joomla:menu-toggle

So all over the place!

Should the prefix be joomla. or joomla: or no prefix like in subforms?

avatar Fedik
Fedik - comment - 8 Nov 2021

Correct is joomla:blabla-event https://docs.joomla.org/J4.x:ClientSideEvents

In subform is an old event, and in joomla 4 it has joomla:updated.

Addittionaly: add bubbles: true to CustomEvent call

avatar regularlabs
regularlabs - comment - 8 Nov 2021

Done.

avatar Fedik
Fedik - comment - 8 Nov 2021

One more thing, please change base branch to 4.1-dev.
Because all new features goes there.

avatar regularlabs regularlabs - change - 8 Nov 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-11-08 21:13:39
Closed_By regularlabs
avatar regularlabs
regularlabs - comment - 8 Nov 2021

Done with: #35994

avatar regularlabs regularlabs - close - 8 Nov 2021

Add a Comment

Login with GitHub to post a comment