[#35989] - [4.0] Clear search when a directory is changed in media manager
- Fixed in Code Base
- 23 Dec 2021
- Medium
- Build: 4.0-dev
- # 35989
- Diff
- Digital-Peak:j4/media/clear/search
User tests: Successful: Unsuccessful:
Pull Request for discussion #35453 (comment).
Summary of Changes
Clears the search in media manager when folder is changed. Similar to a file browser on desktop computer.
@wilsonge and @bembelimen I leave that up to you guys if it should be added to 4.0 or 4.1.
Testing Instructions
- Open the media manager
- Search for banners
- Double click on the banners folder
- Search input field should be cleared
Actual result BEFORE applying this Pull Request
Search remains and banners folder is empty.
Expected result AFTER applying this Pull Request
Search input field is cleared and all items are shown.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration com_media NPM Change Unit Tests |
| Labels |
Added:
?
?
NPM Resource Changed
|
||
@ceford can you please test again, because when I applied patch it didn't getting me the output as expected, may be I am wrong, so can you please test once more, Thanks:)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35989.
For me it works exactly as described in the testing instructions. Did you run npm ci ?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35989.
@pritam825 did you run npm ci after you have applied the patch?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35989.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35989.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35989.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-23 23:40:56 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 7dc55e1
Works as described
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35989.