Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#35969] - [4.0] [bugfix] Fix popover missing content

? ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
5 Nov 2021

Pull Request for Issue #35966.

Summary of Changes

The content in the options object should not be false if not passed from the JS

Testing Instructions

Apply this PR and run npm i
edit the atum index.php and paste this:

<?php HTMLHelper::_('bootstrap.popover','#test_popover', [
  'trigger'   => 'hover focus',
  'placement' => 'right',
]); ?>
<span class="badge bg-info" id="test_popover" data-content="Content" data-bs-content="Content" title="Title">Popover Test</span>

After <div class="container-fluid container-main"> ~line #160

Actual result BEFORE applying this Pull Request

No content
Screenshot 2021-11-05 at 13 27 22

Expected result AFTER applying this Pull Request

Content is taken from the data attribute
Screenshot 2021-11-05 at 13 26 41

Documentation Changes Required

avatar dgrammatiko dgrammatiko - open - 5 Nov 2021
avatar dgrammatiko dgrammatiko - change - 5 Nov 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Nov 2021
Category ⇒ JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - change - 5 Nov 2021
The description was changed
avatar dgrammatiko dgrammatiko - edited - 5 Nov 2021
avatar matteo-galletti matteo-galletti - test_item - 5 Nov 2021 - Tested successfully
avatar matteo-galletti
matteo-galletti - comment - 5 Nov 2021

I have tested this item ✅ successfully on 63d4dec

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35969.

avatar richard67
richard67 - comment - 5 Nov 2021

Does that PR solve issue #35966 ? If so, it would have helped us (bug squad) if you had mentioned the issue in the description of this PR like it should be. I don’t wanna know how many open issues we have where there is a pull request and we don’t know that.

avatar dgrammatiko dgrammatiko - change - 6 Nov 2021
The description was changed
avatar dgrammatiko dgrammatiko - edited - 6 Nov 2021
avatar Quy Quy - test_item - 11 Nov 2021 - Tested successfully
avatar Quy
Quy - comment - 11 Nov 2021

I have tested this item ✅ successfully on 63d4dec

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35969.

avatar Quy Quy - change - 11 Nov 2021
Status Pending ⇒ Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 11 Nov 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35969.

avatar HLeithner HLeithner - change - 12 Nov 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-11-12 07:28:09
Closed_By ⇒ HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 12 Nov 2021
avatar HLeithner HLeithner - merge - 12 Nov 2021
avatar HLeithner
HLeithner - comment - 12 Nov 2021

Thanks

Add a Comment

Login with GitHub to post a comment