No Code Attached Yet
avatar softforge
softforge
26 Oct 2021

Steps to reproduce the issue

Update a site from J4.0.3 to J4.0.4

Expected result

Usual warnings about backups but not the whole pre-update checker

Actual result

The pre-update checker shows and gives lots of warnings

System information (as much as possible)

J4.0.x website that needs updating

Additional comments

I'm assuming any fix will go into J4.0.5 and then we wont see the change until between J4.0.5 to J4.0.6
screen shot 2021-10-26 at 12 08 29
screen shot 2021-10-26 at 12 08 41
screen shot 2021-10-26 at 12 08 53

avatar softforge softforge - open - 26 Oct 2021
avatar softforge softforge - change - 26 Oct 2021
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2021
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 26 Oct 2021
avatar softforge softforge - change - 26 Oct 2021
The description was changed
avatar softforge softforge - edited - 26 Oct 2021
avatar softforge softforge - change - 26 Oct 2021
The description was changed
avatar softforge softforge - edited - 26 Oct 2021
avatar brianteeman
brianteeman - comment - 27 Oct 2021

Are you still having this problem? I don't see it myself and it might have been a cdn cache delay?

avatar zero-24
zero-24 - comment - 27 Oct 2021

As mentiond in other places on a quick look it looks like the call to: shouldDisplayPreUpdateCheck

Has to be added in here:

elseif ($this->getLayout() != 'update' || $isCritical)

Are you still having this problem? I don't see it myself and it might have been a cdn cache delay?

I'm not sure what kind of CDN cache delay could have an impact on whether the pre upgrade check is shown? It could be that the pre upgrade checker shows here because there is the error AcyMailing? Maybe @bembelimen can give some more insight here as he rewrote this stuff for 4.0

avatar softforge
softforge - comment - 27 Oct 2021

@zero-24 and others suggested that the code to stop it had been removed in 4 at some point. So The call to shouldDisplayPreUpdateCheck is not called from com_joomlaupdate https://github.com/joomla/joomla-cms/search?q=shouldDisplayPreUpdateCheck


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35904.

avatar softforge
softforge - comment - 27 Oct 2021

@zero-24 and others suggested that the code to stop it had been removed in 4 at some point. So The call to shouldDisplayPreUpdateCheck is not called from com_joomlaupdate https://github.com/joomla/joomla-cms/search?q=shouldDisplayPreUpdateCheck


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35904.

avatar brianteeman
brianteeman - comment - 29 Oct 2021

i still cannot replicate this

avatar AndNovAtor
AndNovAtor - comment - 31 Oct 2021

I can. STILL.
Updated Joomla 3.10.2 to Jooma 4.0.3. Now 4.0.4 is availible. And pre-update checker still shows. And as it "STUPID" (shows warning any time as ANY extension has not last version), it's hilarrious for Joomla 4
@brianteeman , do you have test Joomla 4.0.3 updated from Joomla 3.10.2, for example (with installed any NOT last version [third-party] extension)? (even, for example, pkg_search with not last version - 4.0.0-dev, as 4.0.1-dev is last version)

avatar AndNovAtor
AndNovAtor - comment - 31 Oct 2021

cache

btw, Joomla 3 have "clear" buton in extension install tab, that clear INSTALLER cache (also affects Joomla check update cache), but sadly there is no such button in Joomla 4

avatar richard67
richard67 - comment - 5 Nov 2021

In J4 that cache clean should be made every time when using the button to search for updates so it doesn't need the extra button anymore.

avatar joomdonation
joomdonation - comment - 6 Nov 2021

PR #35978 should fix this issue. Please test, thanks !

avatar joomdonation joomdonation - close - 6 Nov 2021
avatar joomdonation joomdonation - change - 6 Nov 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-11-06 07:11:39
Closed_By joomdonation

Add a Comment

Login with GitHub to post a comment