? ? NPM Resource Changed Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Oct 2021

Tinymce can be made fullscreen by either the hotkey ctrl-shif-f or by clicking on the icon in the toolbar.

image

This sets the z-index of the editor to 1250. As a result the modals generated by the cms content buttons (editor-xtd pluguins) are invisible as they have a z-index of 1050.

This PR changes the tinymce zindex to 1049

avatar brianteeman brianteeman - open - 26 Oct 2021
avatar brianteeman brianteeman - change - 26 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2021
Category Administration Templates (admin) NPM Change
avatar richard67 richard67 - test_item - 29 Oct 2021 - Tested successfully
avatar richard67
richard67 - comment - 29 Oct 2021

I have tested this item successfully on b5fcec4

Not sure if it's a nice fix with the "!important", but it works, and I have no better idea.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35903.

avatar rjharishabh rjharishabh - test_item - 29 Oct 2021 - Tested successfully
avatar rjharishabh
rjharishabh - comment - 29 Oct 2021

I have tested this item successfully on b5fcec4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35903.

avatar rjharishabh rjharishabh - change - 29 Oct 2021
Status Pending Ready to Commit
avatar rjharishabh
rjharishabh - comment - 29 Oct 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35903.

avatar rjharishabh rjharishabh - change - 29 Oct 2021
Labels Added: NPM Resource Changed ?
avatar brianteeman brianteeman - change - 3 Nov 2021
Labels Added: ?
avatar bembelimen
bembelimen - comment - 7 Nov 2021

@richard67 and @rjharishabh could you please re-test?

avatar rjharishabh rjharishabh - test_item - 7 Nov 2021 - Tested successfully
avatar rjharishabh
rjharishabh - comment - 7 Nov 2021

I have tested this item successfully on c9e7342


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35903.

avatar richard67 richard67 - test_item - 7 Nov 2021 - Tested successfully
avatar richard67
richard67 - comment - 7 Nov 2021

I have tested this item successfully on c9e7342


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35903.

avatar bembelimen bembelimen - change - 7 Nov 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-11-07 12:11:12
Closed_By bembelimen
avatar bembelimen bembelimen - close - 7 Nov 2021
avatar bembelimen bembelimen - merge - 7 Nov 2021
avatar bembelimen
bembelimen - comment - 7 Nov 2021

Thx

avatar brianteeman
brianteeman - comment - 7 Nov 2021

Thank you

Add a Comment

Login with GitHub to post a comment