[#35878] - [4.0] Do not minify tinymce languages
- Closed
- 23 Oct 2021
- Medium
- Build: 4.0-dev
- # 35878
- Diff
- brianteeman:tinymce_minify
User tests: Successful: Unsuccessful:
Because of the way that tinymce works it can only use a language file that is named exactly the same as the language. As a result none of the minified files eg de.min.js will ever be used.
They are also listed as a language in the plugin configuration which is obviously also not correct.
this PR stops the minification of these languages files.
To test you should
- delete the contents of
media\vendor\tinymce\langs - run
npm run build:js - confirm that there are now no *.min.js in the
media\vendor\tinymce\langsfolder
Pull Request for Issue #35646
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
I have tested this item
I've verified that the minified version is never loaded and that the PR fixes the issue that you get "minified languages" in the language selection of the editor plugin settings when switching off automatic language detection so you get the language selection.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35878.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35878.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35878.
There's a better way according to their docs: https://www.tiny.cloud/docs/configure/integration-and-setup/#suffix
@brianteeman can you try removing this line:
That wouldnt stop the build scripts from creating the minified files
There's a better way according to their docs: https://www.tiny.cloud/docs/configure/integration-and-setup/#suffix
Thats for the theme and plugins.
This PR is for the language files
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-10-23 18:43:42 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
that's the last time I touch javascript
Why closed? The PR is right, or do I miss something?
Create an issue. its ignored.
create a pr. suddenly people notice
Well, maybe we just have too many issues so we have lost the overview :-(
@brianteeman I just tried to help. I'm closing my PR so please reopen this one.
And now?
@dgrammatiko I don't think that @brianteeman wanted you to close your PR. Please re-open it.
@richard67 I reopened the other PR
I have tested this item✅ successfully on 1c09c93
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35878.