? ? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar RickR2H
RickR2H
19 Oct 2021

Pull Request for Issue #35792 and #35630.

Summary of Changes

On certain screen size the subhead with the buttons get removed.
Take a look at the issue above,

Testing Instructions

Apply PR and build JS files with "npm run build:js"

Actual result BEFORE applying this Pull Request

Set screen size to 900px. Go to the articles and refresh the page.
The subhead with the buttons with "+ New" and "Options" is not visible.

Expected result AFTER applying this Pull Request

The subhead is visible

Documentation Changes Required

avatar RickR2H RickR2H - open - 19 Oct 2021
avatar RickR2H RickR2H - change - 19 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Oct 2021
Category JavaScript Repository NPM Change
avatar RickR2H RickR2H - change - 19 Oct 2021
The description was changed
avatar RickR2H RickR2H - edited - 19 Oct 2021
avatar RickR2H RickR2H - change - 20 Oct 2021
Title
subhead with buttons is removed on certain breakpoints
Subhead with buttons is removed on certain breakpoints
avatar RickR2H RickR2H - edited - 20 Oct 2021
avatar ricardo1709
ricardo1709 - comment - 23 Oct 2021

I have tested this item successfully on 388fcac


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35860.

avatar ricardo1709 ricardo1709 - test_item - 23 Oct 2021 - Tested successfully
avatar rjharishabh rjharishabh - test_item - 25 Oct 2021 - Tested successfully
avatar rjharishabh
rjharishabh - comment - 25 Oct 2021

I have tested this item successfully on 388fcac


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35860.

avatar rjharishabh rjharishabh - change - 25 Oct 2021
Status Pending Ready to Commit
avatar rjharishabh
rjharishabh - comment - 25 Oct 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35860.

avatar rjharishabh rjharishabh - change - 25 Oct 2021
Labels Added: NPM Resource Changed ?
avatar richard67
richard67 - comment - 29 Oct 2021

@rjharishabh It seems the RTC label got lost when you did set RTC. As far as I can see you did set RTC by changing the status in the issue tracker, and that was right. But maybe you had also added the RTC label in the labels on the issue tracker when doing that? If so, this was wrong. The RTC label will be added automatically by the issue tracker when status changes to "Ready to Commit", but if that label is already set it will be removed.

avatar rjharishabh
rjharishabh - comment - 29 Oct 2021

I have set RTC by changing the status in the tracker, not by changing labels. Don't know how it got lost.

avatar richard67
richard67 - comment - 29 Oct 2021

No problem .. maybe a tracker hickup ?

avatar bembelimen bembelimen - change - 3 Nov 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-11-03 08:56:58
Closed_By bembelimen
Labels Added: ? ?
avatar bembelimen bembelimen - close - 3 Nov 2021
avatar bembelimen bembelimen - merge - 3 Nov 2021
avatar bembelimen
bembelimen - comment - 3 Nov 2021

Thx

Add a Comment

Login with GitHub to post a comment