? ? Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
19 Oct 2021

Summary of Changes

Finder plugins modify component params registry by merging item params. Further code execution occurring during the onContentAfterSave event can get the invalid component params data.

Testing Instructions

Ensure that finder content plugin is enabled.
Edit article and set any setting to non-global, i.e. "Layout", save article.

Actual result BEFORE applying this Pull Request

Test your custom onContentAfterSave event executing after the finder plugin, see that the component param is article param now:
\JComponentHelper::getComponent('com_content')->getParams()->get('article_layout');

Expected result AFTER applying this Pull Request

Component param value is original.

Documentation Changes Required

No.

89837ce 19 Oct 2021 avatar Denitz fix
avatar Denitz Denitz - open - 19 Oct 2021
avatar Denitz Denitz - change - 19 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Oct 2021
Category Front End Plugins
avatar joomdonation joomdonation - test_item - 31 Oct 2021 - Tested successfully
avatar joomdonation
joomdonation - comment - 31 Oct 2021

I have tested this item successfully on 89837ce


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35855.

avatar khu5h1 khu5h1 - test_item - 24 Nov 2021 - Tested successfully
avatar khu5h1
khu5h1 - comment - 24 Nov 2021

I have tested this item successfully on 89837ce


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35855.

avatar richard67 richard67 - change - 28 Nov 2021
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 28 Nov 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35855.

avatar wilsonge wilsonge - change - 28 Nov 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-11-28 17:34:18
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 28 Nov 2021
avatar wilsonge wilsonge - merge - 28 Nov 2021
avatar wilsonge
wilsonge - comment - 28 Nov 2021

Thanks!

avatar zero-24
zero-24 - comment - 28 Nov 2021

A backport of this change to 3.10 has been prepared here: #36141 please test :)

Add a Comment

Login with GitHub to post a comment