[#35854] - [4.0] php memory limit
- Closed
- 13 Nov 2021
- Medium
- Build: 4.0-dev
- # 35854
- Diff
- brianteeman:rtl
User tests: Successful: Unsuccessful:
It is possible to set the memory limit in php to -1 which means unlimited memory.
Unfortunately this was not accounted for in the maths to check if a file could be uploaded.
To test you will need to change the value in your php.ini to memory_limit = -1 and restart the web server.
Then try to upload any file in the media manager and you will see an error message that the file is too large.
Apply this PR and the upload will be successful.
PR for #35853
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer com_media |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35854.
@rjharishabh Could you test again? Thanks in advance.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35854.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35854.
Check upload, post and memory limit if set to unlimited
I tried visual code on github and completely failed... so I write it down here.
Benjamin is right your changes to $post_max_size and $upload_max_filesize is wrong, you have to check this 2 variables to be bigger then 0 (not -1).
also you have to add this check to the ApiController, because it's possible to set the upload size and post size to -1 or 0 (both unlimit)
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-13 21:27:40 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
I’ve re-opened the issue.
I have tested this item✅ successfully on 43ccd32
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35854.