? ? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
17 Oct 2021

Pull Request for Issue # .

Summary of Changes

Update the lists of deleted files in script.php to changes since 4.0.3 and to how the tool "build/deleted_file_check.php" is used. (See this PR for documentation on that: richard67#19 ).

  • The files added with PR #35388 to the deleted files list have been moved from section "// From 4.0.3 to 4.0.4" up to section "// From 3.10 to 4.0".
  • File "administrator/templates/atum/scss/_mixin.scss" which has been removed from the sources with PR #35518 has been added to the deleted files list so it is deleted with a CMS update.
  • Folder "templates/cassiopeia/images/system" has been added to the list of folders to be removed. The only 2 files in that foldfer have been removed with PR # from the souces, and with commit 3261b92 these files have been added to the deleted files list, but the folder has been forgotten so that empty folder will not be deleted with a CMS update.

Testing Instructions

Either code review or update a 4.0.3 or earlier 4.0 version to current 4.0-dev, one time using the latest nightly 4.0 build for the actual result and one time using the update package or URL built by drone for this PR for the expected result.

Actual result BEFORE applying this Pull Request

Unused file "administrator/templates/atum/scss/_mixin.scss" and empty folder "templates/cassiopeia/images/system" are still present after the update.

Expected result AFTER applying this Pull Request

Unused file "administrator/templates/atum/scss/_mixin.scss" and empty folder "templates/cassiopeia/images/system" are not present anymore after the update.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 17 Oct 2021
avatar richard67 richard67 - change - 17 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2021
Category Administration com_admin
avatar chmst
chmst - comment - 18 Oct 2021

I have tested this item successfully on 33587de


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35845.

avatar chmst chmst - test_item - 18 Oct 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 18 Oct 2021

I have tested this item successfully on 33587de


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35845.

avatar RickR2H RickR2H - test_item - 18 Oct 2021 - Tested successfully
avatar RickR2H RickR2H - change - 18 Oct 2021
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 18 Oct 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35845.

avatar wilsonge wilsonge - close - 19 Oct 2021
avatar wilsonge wilsonge - merge - 19 Oct 2021
avatar wilsonge wilsonge - change - 19 Oct 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-10-19 10:56:33
Closed_By wilsonge
Labels Added: ? ? ?
avatar wilsonge
wilsonge - comment - 19 Oct 2021

Thanks!

avatar richard67
richard67 - comment - 19 Oct 2021

Thanks all.

Add a Comment

Login with GitHub to post a comment