? ? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
17 Oct 2021

Pull Request for Issue # .

Summary of Changes

This Pull Request (PR) removes the translation of the groupText item used for the group name of the EOS quickicon plugin's message.

If you check for the other quickicon plugins (except of the phpversioncheck which seems to work differently so I could not find any group name there), the group name is not translated either:

https://github.com/joomla/joomla-cms/blob/3.10-dev/plugins/quickicon/extensionupdate/extensionupdate.php#L70

https://github.com/joomla/joomla-cms/blob/3.10-dev/plugins/quickicon/joomlaupdate/joomlaupdate.php#L79

https://github.com/joomla/joomla-cms/blob/3.10-dev/plugins/quickicon/privacycheck/privacycheck.php#L76

Testing Instructions

  1. Code review: Check the changes made by this PR and compare with the places in code of the other quickicon plugins mentioned in the description above.

  2. Switch on language debug in Global Configuration.

  3. Go to "System -> Control Panel".

  4. Check the group name of the EOS quickicon in the side menu. Currently it should be shown as "UPGRADE INFORMATION" on a clean, current 3.10.2 or latest 3.10 nightly or 3.10-dev branch.
    Result: The group name shows a double translation ??**UPGRADE INFORMATION**??, see section "Actual result BEFORE applying this Pull Request" below.

  5. Apply the patch from this PR and check again the group name of the EOS quickicon in the side menu.
    Result: The group name is shown as properly translated **UPGRADE INFORMATION**, see section " Expected result AFTER applying this Pull Request" below.

Actual result BEFORE applying this Pull Request

j3-eos-plugin-double-translation

Expected result AFTER applying this Pull Request

j3-eos-plugin-double-translation-fixed

Documentation Changes Required

None.

avatar richard67 richard67 - open - 17 Oct 2021
avatar richard67 richard67 - change - 17 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2021
Category Front End Plugins
avatar richard67 richard67 - change - 17 Oct 2021
The description was changed
avatar richard67 richard67 - edited - 17 Oct 2021
avatar richard67 richard67 - change - 17 Oct 2021
The description was changed
avatar richard67 richard67 - edited - 17 Oct 2021
avatar infograf768
infograf768 - comment - 18 Oct 2021

I have tested this item successfully on 8c6070a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35844.

avatar infograf768 infograf768 - test_item - 18 Oct 2021 - Tested successfully
avatar alikon
alikon - comment - 18 Oct 2021

I have tested this item successfully on 8c6070a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35844.

avatar alikon alikon - test_item - 18 Oct 2021 - Tested successfully
avatar alikon alikon - change - 18 Oct 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 18 Oct 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35844.

avatar zero-24
zero-24 - comment - 27 Oct 2021

Merging here thanks ?

avatar zero-24 zero-24 - change - 27 Oct 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-10-27 13:16:51
Closed_By zero-24
Labels Added: ? ? ?
avatar zero-24 zero-24 - close - 27 Oct 2021
avatar zero-24 zero-24 - merge - 27 Oct 2021
avatar richard67
richard67 - comment - 27 Oct 2021

Thanks all.

Add a Comment

Login with GitHub to post a comment