As I started testing I noticed that spacing seems to have changed on the admin dashboard. See below:

After patch:

Before patch:

Isn't codemirror change of the package.json an unrelated change?

@jwaisner I can't replicate it. How are you testing this one, it needs either npm ci or downloading the package from Github

Isn't codemirror change of the package.json an unrelated change?

Yes but #35769

I have tested this item ✅ successfully on 56e44cd

Okay, so I thought I had cleaned my test branch but had residual changes. After resetting my local branch I am not seeing any issues with this PR.

I have tested this item ✅ successfully on 56e44cd

All looks good to me.

RTC

Back to Pending due to not matching styles.

Upon second review I notices that the headers in the admin modules now have an underline which is not conform the current style. To confirm the issue I downloaded and installed the git repo. @dgrammatiko could you please fix this.

@RickR2H that's a Bootstrap bug when a table has a caption and should be fixed upstream instead of monkey patching the code here.
The change, should be:

From

.table>:not(:first-child) {
    border-top:2px solid #dee2e6;
}

.table > tbody:first-of-type {
    border-top:2px solid #dee2e6;
}

Anyways: twbs/bootstrap#35197 twbs/bootstrap#35200

I see what you mean. In my opinion there are three options. Patch it in the templates as override, Merge and accept the changes for now or don't merge at this stage. In all cases is the test valid tho.

In my opinion there are three options.

I wouldn't consider the first as a viable/maintainable option Patch it in the templates as override
So it's down to the maintainers to either accept this PR knowing that Bootstrap has a minor bag with tables+caption or await for 5.1.3. I'm ok with either

I think we let the leads decide...

I have tested this item ✅ successfully on 56e44cd

RTC
Note: PR will introduce a small visual bug that will be patched in the new Bootstrap release

Thanks!