RTC

Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
5 Oct 2021

Pull Request for Issue # .

Summary of Changes

Update BS to 5.1.2

Testing Instructions

Check that all the templates are still ok

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

avatar dgrammatiko dgrammatiko - open - 5 Oct 2021
avatar dgrammatiko dgrammatiko - change - 5 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2021
Category NPM Change
avatar jwaisner
jwaisner - comment - 7 Oct 2021

As I started testing I noticed that spacing seems to have changed on the admin dashboard. See below:

After patch:
image

Before patch:

image

avatar thednp
thednp - comment - 7 Oct 2021

Isn't codemirror change of the package.json an unrelated change?

avatar dgrammatiko
dgrammatiko - comment - 7 Oct 2021

@jwaisner I can't replicate it. How are you testing this one, it needs either npm ci or downloading the package from Github

Screenshot 2021-10-07 at 11 58 37

Isn't codemirror change of the package.json an unrelated change?

Yes but #35769

avatar jwaisner
jwaisner - comment - 8 Oct 2021

I have tested this item successfully on 56e44cd

Okay, so I thought I had cleaned my test branch but had residual changes. After resetting my local branch I am not seeing any issues with this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35766.

avatar jwaisner jwaisner - test_item - 8 Oct 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 14 Oct 2021

I have tested this item successfully on 56e44cd

All looks good to me.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35766.

avatar RickR2H RickR2H - test_item - 14 Oct 2021 - Tested successfully
avatar RickR2H RickR2H - change - 14 Oct 2021
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 14 Oct 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35766.

avatar RickR2H RickR2H - alter_testresult - 14 Oct 2021 - RickR2H: Tested unsuccessfully
avatar RickR2H RickR2H - change - 14 Oct 2021
Status Ready to Commit Pending
avatar RickR2H
RickR2H - comment - 14 Oct 2021

Back to Pending due to not matching styles.

Upon second review I notices that the headers in the admin modules now have an underline which is not conform the current style. To confirm the issue I downloaded and installed the git repo. @dgrammatiko could you please fix this.

Image 6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35766.
avatar dgrammatiko
dgrammatiko - comment - 14 Oct 2021

@RickR2H that's a Bootstrap bug when a table has a caption and should be fixed upstream instead of monkey patching the code here.
The change, should be:

From

.table>:not(:first-child) {
    border-top:2px solid #dee2e6;
}
.table > tbody:first-of-type {
    border-top:2px solid #dee2e6;
}

Anyways: twbs/bootstrap#35197 twbs/bootstrap#35200

avatar RickR2H
RickR2H - comment - 14 Oct 2021

I see what you mean. In my opinion there are three options. Patch it in the templates as override, Merge and accept the changes for now or don't merge at this stage. In all cases is the test valid tho.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35766.

avatar dgrammatiko
dgrammatiko - comment - 14 Oct 2021

In my opinion there are three options.

I wouldn't consider the first as a viable/maintainable option Patch it in the templates as override
So it's down to the maintainers to either accept this PR knowing that Bootstrap has a minor bag with tables+caption or await for 5.1.3. I'm ok with either

avatar RickR2H
RickR2H - comment - 14 Oct 2021

I think we let the leads decide...

avatar RickR2H
RickR2H - comment - 14 Oct 2021

I have tested this item successfully on 56e44cd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35766.

avatar RickR2H RickR2H - test_item - 14 Oct 2021 - Tested successfully
avatar RickR2H RickR2H - change - 14 Oct 2021
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 14 Oct 2021

RTC
Note: PR will introduce a small visual bug that will be patched in the new Bootstrap release


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35766.

avatar wilsonge wilsonge - close - 16 Oct 2021
avatar wilsonge wilsonge - merge - 16 Oct 2021
avatar wilsonge wilsonge - change - 16 Oct 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-10-16 19:38:35
Closed_By wilsonge
Labels Added: RTC
avatar wilsonge
wilsonge - comment - 16 Oct 2021

Thanks!

Add a Comment

Login with GitHub to post a comment