? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
5 Oct 2021

Pull Request for Issue # .

Summary of Changes

Tags for contact is already loaded inside model https://github.com/joomla/joomla-cms/blob/3.10-dev/components/com_contact/models/contact.php#L252-L256, so we do not need to load it again from view class.

Testing Instructions

  1. Use Joomla 3.10
  2. Create a contact. Add some tags for that contact
  3. Create a menu item to link to Single Contact menu item type of com_contact
  4. Access to that menu item

Actual result BEFORE applying this Pull Request

Tags are being displayed OK, but unnecessary code is executed again inside view class to re-get tags from database.

Expected result AFTER applying this Pull Request

Tags are being displayed OK, the unnecessary code is removed, so performance is increased a bit.

avatar joomdonation joomdonation - open - 5 Oct 2021
avatar joomdonation joomdonation - change - 5 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2021
Category Front End com_contact
avatar zero-24 zero-24 - change - 5 Oct 2021
Labels Added: ?
avatar Franzwohlkoenig
Franzwohlkoenig - comment - 11 Oct 2021

I have tested this item successfully on fffa11d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35764.

avatar Franzwohlkoenig Franzwohlkoenig - test_item - 11 Oct 2021 - Tested successfully
avatar zero-24
zero-24 - comment - 12 Oct 2021

I have tested this item successfully on fffa11d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35764.

avatar zero-24 zero-24 - test_item - 12 Oct 2021 - Tested successfully
avatar zero-24
zero-24 - comment - 12 Oct 2021

Merging thanks @joomdonation and @Franzwohlkoenig 👍

avatar zero-24 zero-24 - change - 12 Oct 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-10-12 19:39:07
Closed_By zero-24
avatar zero-24 zero-24 - close - 12 Oct 2021
avatar zero-24 zero-24 - merge - 12 Oct 2021

Add a Comment

Login with GitHub to post a comment