? ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
3 Oct 2021

Pull Request for Issue #35737

Summary of Changes

This is just an implementation of the RFC #35737

  • Commenting out the ES5 generation calls

Testing Instructions

Run npm ci and check that nothing is broken

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

avatar dgrammatiko dgrammatiko - open - 3 Oct 2021
avatar dgrammatiko dgrammatiko - change - 3 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2021
Category Administration com_finder com_users JavaScript Repository Libraries NPM Change Front End Plugins Templates (site)
avatar dgrammatiko dgrammatiko - change - 3 Oct 2021
Labels Added: ? NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2021
Category Administration com_finder com_users JavaScript Repository Libraries NPM Change Front End Plugins Templates (site) JavaScript Repository
avatar dgrammatiko dgrammatiko - change - 3 Oct 2021
Title
[4.1][RFC] Drop es5 4.0 dev
[4.1][RFC] Drop es5
avatar dgrammatiko dgrammatiko - edited - 3 Oct 2021
avatar dgrammatiko dgrammatiko - change - 3 Oct 2021
Labels Removed: NPM Resource Changed
a34d45d 3 Oct 2021 avatar dgrammatiko Meh
1eae744 3 Oct 2021 avatar dgrammatiko sure
avatar HLeithner
HLeithner - comment - 7 Nov 2021

Thanks for this PR, I think we can't remove it till 5.0 but making es5 optional would be great.

avatar dgrammatiko
dgrammatiko - comment - 12 Nov 2021

This should be revisited for v5

avatar dgrammatiko dgrammatiko - close - 12 Nov 2021
avatar dgrammatiko dgrammatiko - change - 12 Nov 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-11-12 22:03:25
Closed_By dgrammatiko

Add a Comment

Login with GitHub to post a comment