[#35735] - [4.0] Showon: fix for nested subform
- Fixed in Code Base
- 5 Oct 2021
- Medium
- Build: 4.0-dev
- # 35735
- Diff
- Fedik:showon-innested-subform
User tests: Successful: Unsuccessful:
Summary of Changes
Fixing showon to work in nested subform.
Should be applied after #35726
Testing Instructions
Apply #35726 patch.
Run npm install
Create nested subform field with showon, example in XML for Custom HTML module:
<field
name="subform_parent"
label="Subform Parent"
type="subform"
multiple="true"
buttons="add,remove"
>
<form>
<field
name="test_text"
label="Test Text"
type="text"
/>
<field
name="child_subform"
label="Child Subform"
type="subform"
multiple="true"
>
<form>
<field
name="child_text"
label="Child Select"
type="list"
default="1"
>
<option value="1">1</option>
<option value="2">2</option>
</field>
<field
name="child_text2"
label="Child Text"
type="text"
showon="child_text:2"
/>
</form>
</field>
</form>
</field>Add parent field, add children field. Check that field "Child Text" visible only when "Child Select" is 2
Actual result BEFORE applying this Pull Request
Not works
Expected result AFTER applying this Pull Request
Works
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
?
NPM Resource Changed
|
||
@Fedik nice & fast work
Now lets move to the next issue of showon: if showon condition of a field in the nested subform refers to a media field, that's somehow doesn't work - until we save the form, In other cases, if showon condition refers to non-media fields, it works as expected. I'll report it in a separate issue.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35735.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35735.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-10-05 14:21:01 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
Thx
I have tested this item✅ successfully on fff763c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35735.