Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#35733] - [4.0] Log everything string

Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
3 Oct 2021

Change label to "enable logs" which makes more sense and is more consistent with other labels

Pull Request for Issue #35349

image

avatar brianteeman brianteeman - open - 3 Oct 2021
avatar brianteeman brianteeman - change - 3 Oct 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2021
Category ⇒ Administration Language & Strings
avatar ChristineWk
ChristineWk - comment - 3 Oct 2021

I have tested this item ✅ successfully on d80fa51

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35733.

avatar ChristineWk ChristineWk - test_item - 3 Oct 2021 - Tested successfully
avatar Fedik
Fedik - comment - 3 Oct 2021

It is misleading now.

It is exactly what it say "log everything":

joomla-cms/libraries/src/Application/CMSApplication.php

Lines 1405 to 1409 in 0c41f6b

// Log everything (except deprecated APIs, these are logged separately with the option above).
if ($this->get('log_everything'))
{
Log::addLogger(['text_file' => 'everything.php'], Log::ALL, ['deprecated', 'deprecation-notes', 'databasequery'], true);
}

User may assume that log is disabled when it Off, but it is not.
Log also may be enabled if you add any category to "Log Categories":

joomla-cms/libraries/src/Application/CMSApplication.php

Line 1411 in 0c41f6b

if ($this->get('log_categories'))

The fix for "Log Categories" description is there #34966

avatar brianteeman
brianteeman - comment - 3 Oct 2021

So "Custom logging" really should be called "Logging Options" and the fields reworked to use showon?

avatar Fedik
Fedik - comment - 3 Oct 2021

hm, not really, Custom logging is about logging of specific category(-ies).
When "Log categories" is empty then Custom logging is disabled,
when example you add jerror,database then it will log only these categories, no mater if "Log everything" On or Off.

It is 2 different sections, which migrated from debug plugin.

avatar brianteeman
brianteeman - comment - 3 Oct 2021

wow this really is a mess. Can't be fixed with a string

avatar brianteeman brianteeman - change - 3 Oct 2021
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-10-03 18:39:03
Closed_By ⇒ brianteeman
Labels Added: Language Change ?
avatar brianteeman brianteeman - close - 3 Oct 2021
avatar Fedik
Fedik - comment - 3 Oct 2021

but please test #34966 that is a fix for misleading description :)

Add a Comment

Login with GitHub to post a comment