? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
3 Oct 2021

PR for #35500

When you are using shared sessions the mod_logged module on the dashboard cannot determine if a user is logged in to the admin or the site.

Before this PR the location was left blank. With this PR the location displays "N/A

To test make sure that you have set shared sessions to on in the global config

avatar brianteeman brianteeman - open - 3 Oct 2021
avatar brianteeman brianteeman - change - 3 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2021
Category Modules Administration
avatar PhilETaylor
PhilETaylor - comment - 3 Oct 2021

Maybe "Shared" would be better than "n/a" ?

avatar brianteeman
brianteeman - comment - 3 Oct 2021

The column name is location so no I dont think "shared" would be better

avatar brianteeman
brianteeman - comment - 13 Oct 2021

Another alternative would be to simply NOT show the location column if the shared session is set

avatar Quy
Quy - comment - 17 Jan 2022

Or "Both". Under Shared Sessions, maybe add description stating that the site logout function will not be available.

avatar brianteeman
brianteeman - comment - 17 Jan 2022

@Quy I understand the code why the logout button doesnt appear I am just wondering why it has been setup this way as this limitation was not present in j3.

avatar brianteeman brianteeman - change - 20 Jan 2022
Labels Added: ?
avatar brianteeman
brianteeman - comment - 20 Jan 2022

Rebased to 4.1

avatar brianteeman brianteeman - change - 20 Jan 2022
Title
[4.0] module shared session
[4.1] module shared session
avatar brianteeman brianteeman - edited - 20 Jan 2022
avatar Quy
Quy - comment - 8 Mar 2022

I have tested this item successfully on 047e666


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35732.

avatar Quy Quy - test_item - 8 Mar 2022 - Tested successfully
avatar laoneo
laoneo - comment - 20 Mar 2022

I have tested this item successfully on 047e666


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35732.

avatar laoneo laoneo - test_item - 20 Mar 2022 - Tested successfully
avatar laoneo laoneo - change - 20 Mar 2022
Status Pending Ready to Commit
avatar laoneo
laoneo - comment - 20 Mar 2022

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35732.

avatar laoneo laoneo - change - 1 Apr 2022
Labels Added: ? ?
Removed: ?
avatar laoneo laoneo - change - 1 Apr 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-04-01 15:40:13
Closed_By laoneo
avatar laoneo laoneo - close - 1 Apr 2022
avatar laoneo laoneo - merge - 1 Apr 2022
avatar laoneo
laoneo - comment - 1 Apr 2022

Thanks!

Add a Comment

Login with GitHub to post a comment