[#35645] - [4.1-dev] Fixing SCSS issues with division deprecation and math.div()
- Closed
- 22 Sep 2021
- Medium
- Build: 4.1-dev
- # 35645
- Diff
- thednp:4.1-dev-scss-fixes
User tests: Successful: Unsuccessful:
Pull Request for PR #35639 .
Important
This PR should be merged into [4.0-dev] as well asap.
Summary of Changes
-
The fontawesome icon library haven't marked their
$fa-fw-widthvariable with!default, see #17482 which uses(20em / 16)expression which is deprecated in dart-sass 2.0 and also largely reported in the fontawesome issues. -
Other changes in this PR also address other dart-sass issues, but we don't replace for instance
24 / 16withmath.div(24, 16)as recommended by the compiler, but with24 * 0.0625(which is the result of 1/16) and the reason for that is the libsass compiler still largely used and this approach is also widely adopted. I suspect scssPhp also might not havemathimplemented. -
See this PR in fontawesome
for more info.
Testing Instructions
Just build and check SASS compiler output.
Actual result BEFORE applying this Pull Request
The compiler just won't do division via the / (forward slash) operator
https://ci.joomla.org/joomla/joomla-cms/47599
Expected result AFTER applying this Pull Request
All scss files compiled successful.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change Repository Installation Front End Templates (site) |
| Title |
|
||||||
If you want it to be merged into 4.0 then you should do the pr on that branch and not 4.1
From your description it implies that its just for fontawesome but I see in the files that it applies elsewhere. Please confirm and update your initial post and test instructions
I need this in 4.1 for #35639.
It is for fontawesome mainly, but also some other minor changes to pass the compiler. As you can see for yourself. So close commit and re-commit to 4.0? and then someone else will merge the change to 4.1?
4.1 branch is important to get that PR solved.
So close commit and re-commit to 4.0?
You don't have to close and reopen you can rebase it to 4.0-dev, eg click on the edit next to the PR's title and then select the branch
I can't do that right now, I'm still working with GH app on the color-picker branch.
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | Administration Templates (admin) NPM Change Repository Installation Front End Templates (site) | ⇒ | Unit Tests Repository Administration com_admin com_associations com_banners com_cache com_checkin com_contact com_content com_finder com_installer com_joomlaupdate com_languages com_media com_menus com_messages com_modules com_newsfeeds |
| Labels |
Added:
?
Removed: NPM Resource Changed |
||
| Category | Administration Repository Unit Tests com_admin com_associations com_banners com_cache com_checkin com_contact com_content com_finder com_installer com_joomlaupdate com_languages com_media com_menus com_messages com_modules com_newsfeeds | ⇒ | Unit Tests Administration com_admin com_associations com_banners com_cache com_checkin com_contact com_content com_finder com_installer com_joomlaupdate com_languages com_media com_menus com_messages com_modules com_newsfeeds com_plugins com_postinstall com_redirect |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-09-22 18:13:05 |
| Closed_By | ⇒ | thednp |
@dgrammatiko and any other please test and push this.