[#35628] - [4.1-dev] Adding color-picker to 4.1
- Closed
- 21 Sep 2021
- Medium
- Build: 4.1-dev
- # 35628
- Diff
- thednp:4.1-dev
User tests: Successful: Unsuccessful:
renamed branch...
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin Language & Strings Templates (admin) NPM Change Repository JavaScript Layout Front End Plugins Templates (site) |
| Labels |
Added:
Language Change
NPM Resource Changed
?
|
||
Unfortunately yes.
Solved, now unfortunately the dart-sass errors kick in now.
| Category | Administration com_admin Language & Strings Templates (admin) NPM Change Repository JavaScript Layout Front End Plugins Templates (site) | ⇒ | Administration com_admin Language & Strings Templates (admin) NPM Change Repository JavaScript Layout Front End Templates (site) |
@brianteeman the build is failing because of dart-sass, it's not related to my changes.
@dgrammatiko this branch uses same version of sass, perhaps the best thing to do is to fix those SCSS issues first, I cannot get a perfect build now unless I fix those SCSS issues which are not related to my commit at all.
| Category | Administration com_admin Language & Strings Templates (admin) NPM Change Repository JavaScript Layout Front End Templates (site) | ⇒ | Administration com_admin Language & Strings Templates (admin) NPM Change Repository JavaScript Layout Front End Plugins Templates (site) |
| Category | Administration com_admin Language & Strings Templates (admin) NPM Change Repository JavaScript Layout Front End Templates (site) Plugins | ⇒ | Administration com_admin Language & Strings Templates (admin) NPM Change Repository JavaScript Layout Front End Templates (site) |
Should I attempt to fix those issues? Guys?
Should I attempt to fix those issues? Guys?
Try to rebase this branch using the latest 4.1-dev
edit 4.1-dev
That won't work for some reason, the button is disabled
EDIT: for any 4.1-dev branch
You have to do that using the git cli
https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase
Try to rebase it to the origin 4.1-dev not your local one
I did rebase -r --root and deleted nearly everything in my local repository.
Oh wait some files are coming back now.
I think I'm gonna start over again tomorrow.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-09-21 19:07:21 |
| Closed_By | ⇒ | thednp |
there are unrelated files in this pr