[#35531] - Allow the translation bot to recompile the htmls
- Fixed in Code Base
- 11 Sep 2021
- Medium
- Build: 4.0-dev
- # 35531
- Diff
- dgrammatiko:patch-7
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Do not exit if composer install was not executed and there is a system variable TRANSLATION_BOT with a value YES
Basically, this allows the translation bot to create the error pages by skipping the composer part
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
@wilsonge a simple review should be enough here, it solves the issue #35379 (comment)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
| Labels |
Added:
?
|
||
looks odd can we add parameter something like --no-vendor-cleanup ? so it's more generic?
ENV vars can be used for the same result. If we go with the --no-vendor-cleanup option in the script we have to add one more procedure in the build.js, basically the ENV way is shorter. That said if you insist I can refactor the build.js to accept --no-vendor-cleanup and do the same
ok then ENV but please change the name ;-)
ok then ENV but please change the name ;-)
Give me an alternative, I'm not good at naming things
How about SKIP_COMPOSER_CHECK?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-09-11 13:56:42 |
| Closed_By | ⇒ | HLeithner |
Thanks
@HLeithner joomla-translation-bot#4
the value is case sensitive
looks odd can we add parameter something like --no-vendor-cleanup ? so it's more generic?