[#35528] - [3.10] Progressive cache fix
- Fixed in Code Base
- 22 Nov 2021
- Medium
- Build: 3.10-dev
- # 35528
- Diff
- Denitz:HTMLdocument__getBuffer()_caches_debug_output
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Backport of #27000 into 3.10
Additionally, we should not cache the debug position!
And only use the renderer class in cache hash, otherwise the custom renderer can produce the different hash on non-different load, i.e. it's the issue with all YooTheme templates.
Testing Instructions
Enable Joomla debug and progressive caching, load a single page in frontend as a guest, see a cache file in /cache/com_module growing on each page load.
Actual result BEFORE applying this Pull Request
See a cache file in /cache/com_modules growing on each page load.
Expected result AFTER applying this Pull Request
The cache file stays same.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
Works as expected! Before applying the PR the cache folder increased. After the PR the cache folder stayed the same size.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35528.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
J3 Issue
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35528.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-22 20:04:05 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Merging thanks.
Additionally, we should not cache the debug position!
Obviously this change from the PR here is missing in 4.0-dev yet, see https://github.com/joomla/joomla-cms/blob/3.10-dev/libraries/src/Document/HtmlDocument.php#L472 and https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Document/HtmlDocument.php#L559 .
I.e. this PR is not a pure back integration of #27000 , and that additional part for not caching the debug module position should be merged up into 4.0-dev.
I have tested this item✅ successfully on 0902640
I can confirm the issue and that the file does no longer grow after each page load with the patch applied.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35528.