Feeling Lucky
?
?
[#35527] - Skip calling callback cache controller if caching is disabled
- Closed
- 22 Oct 2022
- Medium
- Build: 4.0-dev
- # 35527
- Diff
- Denitz:Speed-up_ModuleHelper__moduleCache()
User tests: Successful: Unsuccessful:
Summary of Changes
No need to render a module via callback cache controller if caching is disabled.
Testing Instructions
Enable Joomla caching, apply patch, see no changes except slight cached module rendering time improvement for logged users.
Actual result BEFORE applying this Pull Request
The module is rendered or the module data is loaded via callback cache without storing the data, even if caching is disabled.
Expected result AFTER applying this Pull Request
The callback is executed directly.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Fedik
- comment
- 10 Sep 2021
That may happen if the module itself also use cache, because $params->get('cache') == 1.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
Removed: ? |
||
HLeithner
- comment
- 27 Jun 2022
This pull request has automatically rebased to 4.2-dev.
joomla-bot
- comment
- 27 Jun 2022
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-22 07:43:28 |
| Closed_By | ⇒ | HLeithner |
This method does not used when cache is disabled
https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Document/Renderer/Html/ModuleRenderer.php#L36
So your changes does not make sense.