Feeling Lucky
?
?
[#35481] - [3.10] Fix javascript error for pre-update checker
- Fixed in Code Base
- 4 Sep 2021
- Medium
- Build: 3.10-dev
- # 35481
- Diff
- joomdonation:fix_js_error_for_preupdate_checker
User tests: Successful: Unsuccessful:
Pull Request for Issue #35406 .
Summary of Changes
While updating a site from Joomla 3.10 to Joomla 4, if the site contains a system plugin with single quote or double character in it's name, the pre-update checker will throws some javascript error and update could not be processed
This PR solves it by using addScriptOptions instead of addScriptDeclaration to pass nonCoreCriticalPlugins data to javascript.
Testing Instructions
- Install 3.10.1
- Install and enable the attached system plugin. (I set the name to System Fake's , contains single quote character)
- Set Update Channel to Joomla Next
- Access to Components -> Joomla! Update to try to update from Joomla 3.10 to Joomla 4.
- Before patch, check browser console, you will see some javascript error
- After patch, no error, pre-update checker works as expected
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate JavaScript |
ChristineWk
- comment
- 4 Sep 2021
I have tested this item
will delete now the nice plugin :-)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35481.
krogias
- comment
- 4 Sep 2021
Tested successfully
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
richard67
- comment
- 4 Sep 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35481.
zero-24
- comment
- 4 Sep 2021
Merging thanks
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-09-04 18:37:45 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 26ca1ca
Works good for me. Thanks @joomdonation
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35481.