NPM Resource Changed ? Failure

User tests: Successful: Unsuccessful:

avatar sakiss
sakiss
3 Sep 2021

Pull Request for Issue # .

Summary of Changes

The current workflow with the smart search suggestions is to 1st select the suggestion and then submit the form (pressing enter or clicking on the submit button).

This simplifies the process and loads the results once a suggestion is selected.

Testing Instructions

After applying the patch, run npm install
Use the smart search with the suggestions enabled and click on a suggestion to get the results straight.

DO NOTE: That feature will not work on purpose, in the advanced form, for obvious reasons

Actual result BEFORE applying this Pull Request

1st select the suggestion and then submit the form

Expected result AFTER applying this Pull Request

Get the results on selecting a suggestion.

Documentation Changes Required

No

avatar sakiss sakiss - open - 3 Sep 2021
avatar sakiss sakiss - change - 3 Sep 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Sep 2021
Category JavaScript Repository NPM Change
avatar sakiss sakiss - change - 6 Sep 2021
Labels Added: NPM Resource Changed ?
avatar sakiss sakiss - change - 6 Sep 2021
The description was changed
avatar sakiss sakiss - edited - 6 Sep 2021
avatar sakiss
sakiss - comment - 8 Sep 2021

@richard67 Do you think that this fits in the J 4.0 branch?

avatar richard67
richard67 - comment - 8 Sep 2021

@richard67 Do you think that this fits in the J 4.0 branch?

I don't know, and it's not on me to decide since I'm not a release lead.

avatar sakiss
sakiss - comment - 9 Sep 2021

I am closing that as i created a PR for J4.0. Let's how this will go.

avatar sakiss sakiss - close - 9 Sep 2021
avatar sakiss sakiss - change - 9 Sep 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-09-09 17:40:42
Closed_By sakiss

Add a Comment

Login with GitHub to post a comment