Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#35458] - [4] void method result used

?
avatar PhilETaylor
PhilETaylor
1 Sep 2021

Summary of Changes

enqueueMessage is a method that doesnt return (I.e void return type)

You cannot "return" a void it "just is" and therefore this implementation is wrong.

Testing Instructions

Code review. Simple

Actual result BEFORE applying this Pull Request

Everything works. Static analysis complains. phpStorm complains. psalm complains. PHPStan Complains.

Expected result AFTER applying this Pull Request

Everything works.

Documentation Changes Required

None.

avatar PhilETaylor PhilETaylor - open - 1 Sep 2021
avatar PhilETaylor
PhilETaylor - comment - 1 Sep 2021

Drone failure unrelated

9	  [ConnectionException] Can't connect to WebDriver at http://127.0.0.1:4444/wd/hub. Make sure that ChromeDriver, GeckoDriver or Selenium Server is running.
avatar Quy Quy - change - 22 Dec 2021
The description was changed
Labels Added: ?
avatar Quy Quy - edited - 22 Dec 2021
avatar joomla-cms-bot joomla-cms-bot - change - 22 Dec 2021
Category ⇒ Administration com_joomlaupdate
avatar Quy
Quy - comment - 22 Dec 2021

Tested successfully.

avatar wilsonge wilsonge - close - 30 Dec 2021
avatar wilsonge wilsonge - merge - 30 Dec 2021
avatar wilsonge wilsonge - change - 30 Dec 2021
Status New ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-12-30 20:51:40
Closed_By ⇒ wilsonge
avatar wilsonge
wilsonge - comment - 30 Dec 2021

Thanks!

Add a Comment

Login with GitHub to post a comment