? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
1 Sep 2021

Pull Request for Issue #35094 .

Summary of Changes

Transitions are now translateable everywhere.

For example:

Backend article edit view:
grafik

Backend article list view:
grafik

Testing Instructions

  • Make a fresh install of this PR
  • Activate the workflow
  • Go to the transitions
  • See that there are now language keys as title
  • Check the different occurrence of the transitions (backend/frontend edit article, list view backend)
  • Use own language keys in transitions + language override function.

Actual result BEFORE applying this Pull Request

Transitions are not (everywhere) translated

Expected result AFTER applying this Pull Request

Transitions are translated everywhere.

avatar bembelimen bembelimen - open - 1 Sep 2021
avatar bembelimen bembelimen - change - 1 Sep 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Sep 2021
Category Administration com_content Language & Strings SQL Installation Postgresql Libraries
avatar bembelimen bembelimen - change - 1 Sep 2021
Labels Added: Language Change ?
avatar joomla-cms-bot joomla-cms-bot - change - 1 Sep 2021
Category Administration com_content Language & Strings SQL Installation Postgresql Libraries SQL Administration com_admin Postgresql com_content Language & Strings Installation Libraries
avatar Kostelano
Kostelano - comment - 1 Sep 2021

Probably, we need to add new lines including to api/language/en-GB/joomla.ini

avatar brianteeman
brianteeman - comment - 1 Sep 2021

Yes please, at least for now, it is helpful if we just keep these files in sync

avatar brianteeman
brianteeman - comment - 1 Sep 2021

I am not a fan of editing previous update sql. They should be immutable.

avatar brianteeman
brianteeman - comment - 1 Sep 2021

Also the update sql you have will fail on an existing site.

/* SQL Error (1062): Duplicate entry '1' for key 'hvu3i_workflow_transitions.PRIMARY' */

avatar richard67
richard67 - comment - 1 Sep 2021

I am not a fan of editing previous update sql. They should be immutable.

@brianteeman I thought you meanwhile had understand that "immutable" is wrong due to all my past work on old update SQL files. And here you are again wrong: We can and should change the old update SQL because there is no risk in doing it and it makes the workflow transitions to be translatable also after update from 3.10 to 4.0.

Also the update sql you have will fail on an existing site.
/* SQL Error (1062): Duplicate entry '1' for key 'hvu3i_workflow_transitions.PRIMARY' */

Than only happens if you apply the update SQL changed by this PR to a Joomla 4 database. But that will never happen since this SQL will only run when updating a 3.10.

avatar brianteeman
brianteeman - comment - 1 Sep 2021

I stick by my views

avatar richard67
richard67 - comment - 1 Sep 2021

As usual.

avatar brianteeman
brianteeman - comment - 1 Sep 2021

No point in having opinions if you don't believe in them. To repeat it's not about the technical need but as pointed out previously by another user changes to existing dated files can break complex work flows for server management

avatar bembelimen
bembelimen - comment - 1 Sep 2021

Hello,
thanks for the feedback.

Also the update sql you have will fail on an existing site.

/* SQL Error (1062): Duplicate entry '1' for key 'hvu3i_workflow_transitions.PRIMARY' */

My concerns were, that I didn't want to change existing workflows, so I updated only the 3.x => 4.x path, not adding a new file which changes existing data. How did you raise this error? Could you give me please a little guide, so I can fix it?

avatar brianteeman
brianteeman - comment - 1 Sep 2021

If you are updating manually (perhaps you want to keep everything in github) then its reasonable to assume that someone would run the sql updates manually. Thats when you get the error. also see #22754

My concerns were, that I didn't want to change existing workflows,

So now we have two sites with different data depending on when they were installed

When you now tell a user that workflows are translatable and they just need to create a language override it will only work on one of the two sites.

If you do an update query instead then everyone is on the same data (unless they changed the text already in which case their changed data is untouched)

UPDATE #__workflow_transitions SET title="PUBLISH_AND_FEATURE" WHERE title = "Publish & Feature"

avatar bembelimen
bembelimen - comment - 4 Sep 2021

Thanks @brianteeman I've pushed the update files.

avatar Kostelano Kostelano - test_item - 5 Sep 2021 - Tested successfully
avatar Kostelano
Kostelano - comment - 5 Sep 2021

I have tested this item successfully on c091084


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35457.

avatar RickR2H RickR2H - test_item - 9 Sep 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 9 Sep 2021

I have tested this item successfully on c091084

All overrides work!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35457.

avatar richard67
richard67 - comment - 9 Sep 2021

@bembelimen This PR has conflicts now due to the names of the SQL update scripts already being used. That comes from the merged PR #35483 . Could you solve that?

avatar richard67
richard67 - comment - 11 Sep 2021

Conflict solved, Since it doesn't have changed anything on what was relevant for the test, I restore the test results in the issue tracker so they are counted, and will set RTC.

avatar richard67 richard67 - alter_testresult - 11 Sep 2021 - Kostelano: Tested successfully
avatar richard67 richard67 - alter_testresult - 11 Sep 2021 - RickR2H: Tested successfully
avatar richard67 richard67 - change - 11 Sep 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 11 Sep 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35457.

avatar wilsonge wilsonge - change - 11 Sep 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-09-11 21:58:57
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 11 Sep 2021
avatar wilsonge wilsonge - merge - 11 Sep 2021
avatar wilsonge
wilsonge - comment - 11 Sep 2021

Thanks!

Add a Comment

Login with GitHub to post a comment