[#35424] - [4.3] Fix language constants overrides in com_template.inis and com_categories.ini
- Fixed in Code Base
- 21 Oct 2022
- Medium
- Build: 4.0-dev
- # 35424
- Diff
- wojsmol:patch-8
User tests: Successful: Unsuccessful:
Pull Request for Issue #35422 .
Summary of Changes
Fix language constants overrides in com_template.inis and com_categories.ini
Testing Instructions
code review
Actual result BEFORE applying this Pull Request
Original JLIB constants are used.
Expected result AFTER applying this Pull Request
Component specific constants are used
Documentation Changes Required
N/A
| Title |
|
||||||
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
| Title |
|
||||||
@Kostelano Other contacts have the same issue - no component specific when using as a override.
I have tested this item
This is not a valid change.
Test it (for example, create an override, install the nightly version and look at your new constants) and you can see why.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35424.
Thanks! I can't submit a test yet as I have doubts about line JLIB_RULES_SETTING_NOTES_ITEM_COM_CATEGORIES. There should probably be a section similar to JLIB_RULES_SETTING_NOTES_ITEM_COM_CONTENT_ARTICLE.
| Labels |
Added:
Language Change
?
?
|
||
This pull request has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
| Title |
|
||||||
| Labels |
Added:
?
PR-4.3-dev
?
Removed: ? ? |
||
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-21 15:43:13 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Removed:
?
|
||
Thanks!
The change needed to be done for 3.10, but okay.
However, this is wrong.
Why did you change the other constants (except for the last one in every file)?