[#35392] - [4] Remove check for memory_limit when uploading files
- Pending
- Medium
- Build: 4.0-dev
- # 35392
- Diff
- PhilETaylor:patch-258
User tests: Successful: Unsuccessful:
Pull Request for Issue #35360
Summary of Changes
Remove check to memory_limit when uploading files.
Testing Instructions
try to upload files bigger than memory_limit
Specifically from #35360
- setup plain joomla4 instance at php 8.0 or 7.3 or 7.4 with mysql 5.7
- keep standard setup values for uploads
- set server memory_limit to -1 (=no limit)
- upload an image via Menu -> Content -> Media
Actual result BEFORE applying this Pull Request
File uploads would fail if larger than memory_limit or if ini_get('memory_limit) === -1
Expected result AFTER applying this Pull Request
File Uploaded, even larger than memory_limit upload without issue.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media |
| Title |
|
||||||
You mean in com_installer?
which just shows warnings if your setting is below the default 32M like something like 16M or 24M (assuming the comments are correct)? If your server is running with memory_limit 16M then I would change web hosts.
-I would expect reason to limit it is prevent error messages for code like $x = file_get_contents() but that code should shouldn't exists if you expect files lager then 1 mb
Im not here to teach everyone about PHP basics. Sorry I dont have time for that.
dont take my word for it. Do your own research.
file_get_contents is not used to "upload files" over http in com_media or com_installer, and there is (or should never be) anywhere in Joomla where we are trying to load the full content of huge files into memory.
All this chat is unrelated to this PR and the problem it resolves.
@PhilETaylor could you please resolve conflicts?
Closing as has no chance or being merged
/me confused memory_limit is used in the installer as well