Publish a menu module with layout default
to the topbar
position of the Cassiopeia template. Login to the Joomla frontend. Check the markup of the module in the frontend.
Valid markup.
<ul class="mod-menu mod-list nav foo-bar">
<a class="btn btn-link jmodedit" href="#" target="_self" aria-describedby="tip-123">
<span class="icon-edit" aria-hidden="true"></span><span class="visually-hidden">Edit</span></a>
<div role="tooltip" id="tip-123">Edit Module<br>Test Menu<br>Position: below-top</div>
<li class="nav-item item-101 default current active"></li>
</ul>
Joomla 4.0.*
The following line https://github.com/joomla/joomla-cms/blame/4.0-dev/layouts/joomla/edit/frontediting_modules.php#L40 will create invalid markup, if the module's outer tag is an <ul>
or <ol>
. (e.g.
The Unordered List element <ul
may only contain <li>
, <template>
, <script>
child elements.
Introduced with 678e929
Labels |
Added:
No Code Attached Yet
|
Labels |
Added:
Information Required
|
@brianteeman I just updated the Steps to reproduce. Maybe it needs to be the topbar
position, because the module does not get wrapped there.
Yes that was it. It is a bug but very low priority. Do you have an idea how to fix it
I can only think of wrapping the modules in an extra <div>
.
Trying to insert the button into the first <li>
can possibly fail if there is none.
Can't really see the point myself
Can someone remove the information required tag please
Labels |
Removed:
Information Required
|
Labels |
Added:
bug
|
I can not replicate this - maybe it was changed since the issue was first created