Feeling Lucky
?
?
NPM Resource Changed
[#35339] - [4] Fix spinner bg
- Fixed in Code Base
- 25 Aug 2021
- Medium
- Build: 4.0-dev
- # 35339
- Diff
- PhilETaylor:fixwhitebgonspinner
User tests: Successful: Unsuccessful:
Pull Request for Issue #35334
Summary of Changes
dont hardcode color
remember to nom run build:js
Testing Instructions
slow down the checking of fetchExtensionCompatibility method by putting in a sleep(10); in the method.
look at the icons - click the tab on and off checking the colour - after 10 seconds see triangle has white bg
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate JavaScript Repository NPM Change |
alikon
- comment
- 24 Aug 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35339.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 24 Aug 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35339.
| Labels |
Added:
?
?
NPM Resource Changed
|
||
Quy
- comment
- 24 Aug 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35339.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-25 11:17:56 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
Removed: ? |
||
wilsonge
- comment
- 25 Aug 2021
Thanks!
I have tested this item✅ successfully on 0a9f164
thanks - i missed the text-info in my attempt
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35339.