Feeling Lucky
?
?
NPM Resource Changed
[#35294] - [4] Highlight the Home Dashboard link only when active page
- Fixed in Code Base
- 22 Aug 2021
- Medium
- Build: 4.0-dev
- # 35294
- Diff
- PhilETaylor:fixadminmenuhomhighlight
User tests: Successful: Unsuccessful:
Pull Request for Issue #34484
Summary of Changes
Only highlight the Home Dashboard if the current url is the index.php page
Testing Instructions
Visit the Home Dashboard in Joomla 4 admin - Note Home Dashboard is highlighted
Go to any other menu item - note Home Dashboard is not highlighted but the correct item is.
Actual result BEFORE applying this Pull Request
Home Dashboard is always highlighted
Expected result AFTER applying this Pull Request
Home Dashboard is only highlighted when actually the page we are on
Documentation Changes Required
none.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
brianteeman
- comment
- 22 Aug 2021
I have tested this item
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35294.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 22 Aug 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35294.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-22 22:15:31 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
NPM Resource Changed
|
||
wilsonge
- comment
- 22 Aug 2021
Thanks!
I have tested this item✅ successfully on 5f3ba2e
Fix works. "Home Dashboard" is now only set as active if we are on the dashboard.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35294.