? ? NPM Resource Changed Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
22 Aug 2021

Pull Request for Issue #34484

Summary of Changes

Only highlight the Home Dashboard if the current url is the index.php page

Testing Instructions

Visit the Home Dashboard in Joomla 4 admin - Note Home Dashboard is highlighted
Go to any other menu item - note Home Dashboard is not highlighted but the correct item is.

Actual result BEFORE applying this Pull Request

Home Dashboard is always highlighted

Expected result AFTER applying this Pull Request

Home Dashboard is only highlighted when actually the page we are on

Documentation Changes Required

none.

avatar PhilETaylor PhilETaylor - open - 22 Aug 2021
avatar PhilETaylor PhilETaylor - change - 22 Aug 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Aug 2021
Category JavaScript Repository NPM Change
avatar RickR2H RickR2H - test_item - 22 Aug 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 22 Aug 2021

I have tested this item successfully on 5f3ba2e

Fix works. "Home Dashboard" is now only set as active if we are on the dashboard.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35294.

avatar brianteeman brianteeman - test_item - 22 Aug 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 22 Aug 2021

I have tested this item successfully on 5f3ba2e

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35294.

avatar richard67 richard67 - change - 22 Aug 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 22 Aug 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35294.

avatar wilsonge wilsonge - change - 22 Aug 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-08-22 22:15:31
Closed_By wilsonge
Labels Added: ? ? NPM Resource Changed
avatar wilsonge wilsonge - close - 22 Aug 2021
avatar wilsonge wilsonge - merge - 22 Aug 2021
avatar wilsonge
wilsonge - comment - 22 Aug 2021

Thanks!

Add a Comment

Login with GitHub to post a comment