Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#35261] - [4] Comparison may cause unexpected type coercion

? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
20 Aug 2021

Code review

Comparison document.adminForm.boxchecked.value==0 may cause unexpected type coercion according to phpStorm and JSLint.

On evaluating document.adminForm.boxchecked.value on any list view you can see the value is actually a string when returned, so it makes sense to be evaluated as one

avatar PhilETaylor PhilETaylor - open - 20 Aug 2021
avatar PhilETaylor PhilETaylor - change - 20 Aug 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Aug 2021
Category ⇒ Layout
avatar PhilETaylor PhilETaylor - change - 22 Aug 2021
Labels Added: ?
avatar joomdonation joomdonation - test_item - 22 Aug 2021 - Tested successfully
avatar joomdonation
joomdonation - comment - 22 Aug 2021

I have tested this item ✅ successfully on 67e6a10

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35261.

avatar PhilETaylor PhilETaylor - change - 30 Dec 2021
Labels Added: ?
Removed: ?
avatar PhilETaylor PhilETaylor - change - 6 Mar 2022
Labels Added: ?
Removed: ?
avatar PhilETaylor PhilETaylor - change - 7 Mar 2022
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-03-07 18:33:48
Closed_By ⇒ PhilETaylor
avatar PhilETaylor PhilETaylor - close - 7 Mar 2022

Add a Comment

Login with GitHub to post a comment