Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#35260] - [4] Dont use native constant that might be unavailable.

? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
20 Aug 2021

Code review

PASSWORD_ARGON2ID php native constant is only available from PHP 7.3.0 onwards whereas Joomla 4 has to support 7.2.5

PHP may also be compiled without argon support and therefore this constant would not be available.

Just like stated (repeatedly) in UserHelper

joomla-cms/libraries/src/User/UserHelper.php

Line 46 in 55b02c9

* Note: PHP's native `PASSWORD_ARGON2I` constant is not used as PHP may be compiled without this constant

avatar PhilETaylor PhilETaylor - open - 20 Aug 2021
avatar PhilETaylor PhilETaylor - change - 20 Aug 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Aug 2021
Category ⇒ Libraries
avatar PhilETaylor
PhilETaylor - comment - 20 Aug 2021

I see my stalker has returned.

Screenshot 2021-08-20 at 18 43 20

avatar PhilETaylor PhilETaylor - change - 20 Aug 2021
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-08-20 17:46:30
Closed_By ⇒ PhilETaylor
Labels Added: ?
avatar PhilETaylor PhilETaylor - close - 20 Aug 2021
avatar Fedik
Fedik - comment - 20 Aug 2021

You have to use

defined('BLABLA') ? BLABLA : FALLBACK_BLABLA

But I cannot say anything about PASSWORD_ARGON2ID and possible fallbacks

Add a Comment

Login with GitHub to post a comment