[#3526] - [#33595] Incorrect string truncate in com_tags 'tag' view 'default' layout
- Closed
- 12 Nov 2015
- Medium
- Build: staging
- # 3526
- Diff
- tQuant:tagViewStringTruncate
- Foreign ID 33595
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Incorrect string truncate in com_tags 'tag' view 'default' layout. Depending on the length of the html tags, the article body can be reduced to one word, if not be empty at all. There must be used 'string.truncateComplex' instead of 'string.truncate'
Tracker:
nicksavov
- | Labels |
Removed:
?
|
||
| Status | New | ⇒ | Pending |
| Category | ⇒ | Tags |
Possible partial failed test if I understand correctly what you're trying to achieve. This only worked when I extended the number of characters - I used ruth@viryagroup.com as my email address, with max chars set to 80 I just see
This email address is being protected from spambots. You need JavaScript
whereas before I applied the patch I could only see
This email address is being protected from spambots.
The only way to see my email address is to increase the character count to 95, then I see the email address correctly (whereas before the patch, I couldn't see my email address regardless of the number of characters). Below 95, I still see the broken javascript, however.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3526.
The plugin "emailcloak" was changed since testing instuctions was writen.
New testing Instructions
Create article that contain only email address in the body and assign any tag. Create menu item with type 'Tagged items' for that tag and with 'Item description' set to 'show' and 'Maximum Characters' set to '220'.
View new menu item on fromt-end.
Before PR is applied, in the page source code instead of the address a broken javascript is displayed.
After PR is applied, address displayed correctly.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3526.
The problem for me is that even after the patch you need to set the number of character to be large otherwise you get the same issue. So yes its an issue but no I dont think this is the correct solution. As a user I would expect to only need to set the number of characters to equal to or slightly longer than the longest email address
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3526.
| Status | Pending | ⇒ | Information Required |
Hello @tQuant,
Thank you for your contribution.
The last comment here was on 3rd January. So the question is, Is this issue/pull request still valid? Can you also have a look at the comment by Brian?
If no reply is received within 4 weeks we will close this issue.
Thanks for understanding!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3526.
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-12 13:02:48 |
| Closed_By | ⇒ | brianteeman |
Testing Instructions for Joomla 3.3
Create article that contain only email address in the body and go to the 'tag' view (with 'Item description' set to 'show' and 'Maximum Characters' set to '80') . Before PR is applied, address not displayed and in the page source code instead of the address a broken javascript is displayed (in other cases it also can affect DOM structure). After PR is applied, address displayed correctly.