? ? Success

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
18 Aug 2021

Summary of Changes

On multilingual sites the translations of language strings falls back to the default language (when not in debug mode). But if you have created some language overrides this behaviour does not apply.

Testing Instructions

  • Create a multlingual page
  • Install and activate at least one additional language to en-GB
  • Create a language override for a not existing constant like: TEST_CONSTANT="Test" for the english frontend language
  • open the index.php of your frontend template and put: echo Text::_('TEST_CONSTANT');
  • Switch to the 2nd language

Actual result BEFORE applying this Pull Request

TEST_CONSTANT is outputted.

Expected result AFTER applying this Pull Request

Test is outputted.

avatar bembelimen bembelimen - open - 18 Aug 2021
avatar bembelimen bembelimen - change - 18 Aug 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Aug 2021
Category Libraries
avatar wilsonge wilsonge - change - 20 Aug 2021
Labels Added: ?
ee4dd24 20 Aug 2021 avatar wilsonge PHPCS
avatar maikol-ortigueira maikol-ortigueira - test_item - 20 Aug 2021 - Tested successfully
avatar maikol-ortigueira
maikol-ortigueira - comment - 20 Aug 2021

I have tested this item successfully on ee4dd24

I've tested successfully.

Thank you.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35209.

avatar BertaOctech BertaOctech - test_item - 20 Aug 2021 - Tested successfully
avatar BertaOctech
BertaOctech - comment - 20 Aug 2021

I have tested this item successfully on ee4dd24

Applying the patch had the described effect

Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35209.

avatar Quy Quy - change - 20 Aug 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 20 Aug 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35209.

avatar drmenzelit drmenzelit - change - 23 Aug 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-08-23 10:17:51
Closed_By drmenzelit
Labels Added: ? ?
Removed: ?
avatar drmenzelit drmenzelit - close - 23 Aug 2021
avatar drmenzelit drmenzelit - merge - 23 Aug 2021
avatar drmenzelit
drmenzelit - comment - 23 Aug 2021

Thanks

Add a Comment

Login with GitHub to post a comment