Feeling Lucky
?
[#35155] - [4.0] Load default language overrides
- Closed
- 17 Aug 2021
- Medium
- Build: 4.0.1
- # 35155
- Diff
- bembelimen:4.0/load-default-overrides
User tests: Successful: Unsuccessful:
Summary of Changes
On multilingual sites the translations of language strings falls back to the default language (when not in debug mode). But if you have created some language overrides this behaviour does not apply.
Testing Instructions
- Create a multlingual page
- Install and activate at least one additional language to en-GB
- Create a language override for a not existing constant like:
TEST_CONSTANT="Test"for the english frontend language - open the index.php of your frontend template and put:
echo Text::_('TEST_CONSTANT'); - Switch to the 2nd language
Actual result BEFORE applying this Pull Request
TEST_CONSTANT is outputted.
Expected result AFTER applying this Pull Request
Test is outputted.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_admin com_joomlaupdate com_tags com_users Language & Strings Modules NPM Change JavaScript Front End com_content |
| Labels |
Added:
?
Language Change
NPM Resource Changed
?
|
||
| Category | Unit Tests Repository Administration com_admin com_joomlaupdate com_tags com_users Language & Strings Modules NPM Change JavaScript Front End com_content | ⇒ | Libraries |
ricardo1709
- comment
- 17 Aug 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35155.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-17 23:37:07 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
Removed: ? Language Change NPM Resource Changed ? |
||
wilsonge
- comment
- 17 Aug 2021
I'm really sorry I closed down the 4.0.1 branch. Can you recreate this against 4.0-dev. If you tag I'll restore the good tests on the issue tracker.
I have tested this item✅ successfully on b432bc3
Works!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35155.