[#35154] - [J4] not working switch RECORD HITS
- Fixed in Code Base
- 23 Aug 2021
- Medium
- Build: 4.0-dev
- # 35154
- Diff
- korenevskiy:patch-2
User tests: Successful: Unsuccessful:
In the Article settings. The RECORD HITS field is disabled.
But this value is displayed on the site.
The fact is that the disabled RECORD HITS field hides another HITS field.
I believe that it should be like this:
- Either the RECORD HITS field will not hide the HITS field.
- Either disabling the RECORD HITS field will automatically deactivate the HITS field.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35154.
@korenevskiy Does this PR solve your issue #35043 ? If yes then please mention the issue in the dexcription of your PR like it should be and like it is suggested by the PR template when creating a new PR:
Pull Request for Issue #35043 .
And the headings for testing instructions we also don't have without reason in our PR templates.
And finally, please close your issue when having made a PR which claims to solve it.
Thanks in advance.
In general we have that problem everywhere where we use showon because we normally don't use js to reset fields to their default value when they are hidden. It always can happen you hide a field by changing an option but that field still has its value. That's a general issue with showon.
@richard67 that is true but its rarely an issue - here it is
@richard67 that is true but its rarely an issue - here it is
@brianteeman Yes, I agree, and it can be a valid scenario for some site owner to stop recording hits but still show the old count and so have these 2 options independently.
@brianteeman What's funny: It was you who implemented it with PR #32920 ;-) But well, things happen.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35154.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35154.
In general we have that problem everywhere where we use showon because we normally don't use js to reset fields to their default value when they are hidden. It always can happen you hide a field by changing an option but that field still has its value. That's a general issue with showon.
I think that JS is not needed ever. ShowOn needs to be checked in PHP as well. Just in PHP conditions, you need to do double checks of 2 fields. The fact is that there may be cases when you do not need to reset hidden fields to default values. For example, a hidden text field will simply store the text. But we will not use it. I think that we have no problems with hidden fields.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-23 01:08:49 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
?
|
||
Thx
Can the patch be removed?.
Removing the patch will not affect the PR?
@korenevskiy Once merged, it is safe to remove the patch.
#35043