? NPM Resource Changed Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
17 Aug 2021

Pull Request for Issue #35169

Summary of Changes

  • replace the npm package watch with chokidar, the latter is well supported and used by Rollup (which also used by the tools)
  • Remove unused Babel plugins
  • Combine #35048

Testing Instructions

Test if npm install works correctly
Test if npm run watch works correctly

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

#35048 had a very good question from @richard67 for the cleanUpFolders:

Will someone remember to maintain this hardcoded list if some new extension which has assets will be added or removed in future?

The answer is that I can add a little script that extracts these programmatically (run on build.php) so nobody will ever have to do anything). But that will be on another PR...

avatar dgrammatiko dgrammatiko - open - 17 Aug 2021
avatar dgrammatiko dgrammatiko - change - 17 Aug 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2021
Category JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - change - 17 Aug 2021
The description was changed
avatar dgrammatiko dgrammatiko - edited - 17 Aug 2021
avatar wilsonge wilsonge - close - 17 Aug 2021
avatar wilsonge wilsonge - merge - 17 Aug 2021
avatar wilsonge wilsonge - change - 17 Aug 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-08-17 18:52:53
Closed_By wilsonge
Labels Added: ? NPM Resource Changed
avatar wilsonge
wilsonge - comment - 17 Aug 2021

Thanks!

Add a Comment

Login with GitHub to post a comment