[#35177] - [4.1] [GSoC 21] Media Manager - Add a player plugin to better preview audio and video files
- Closed
- 5 Nov 2021
- Medium
- Build: 4.1-dev
- # 35177
- Diff
- eyvazahmadzada:media-types
User tests: Successful: Unsuccessful:
Pull Request for the "Media Type Improvements" task of the final evaluation period of Media Manager.
Summary of Changes
- Add and improve video/audio preview by using the MediaElement player plugin.
Testing Instructions
- Upload files. Upload video or audio files in Media Manager.
- Preview. Preview them by either double-clicking on them or using the "Preview Item" button. Video files:
Audio files:
Documentation Changes Required
I don't think so.
Special thanks to my mentors (@sebenns, @fancyFranci, @GeraintEdwards, @shivamdiehard, Chris Keen) and @bembelimen for assisting me with the project.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change Repository |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35177.
@eyvazahmadzada what is the benefit here by introducing a userland JS media player instead of using the Browser provided one (0kb)?
Having just demoed that we already can do this I was thinking the same
Having just demoed that we already can do this I was thinking the same
Also if it's just about the looks: https://developer.mozilla.org/en-US/docs/Web/Guide/Audio_and_video_delivery/Video_player_styling_basics
Thank you for your comments, @brianteeman, @dgrammatiko. To be honest, most of the tasks about media types in media manager that I had set at the beginning and done during the program have already been done and merged during the period when I was working on them. Back then, the video player was a bit messy so I thought it would be better to use a plugin to make it look better, but now I will try to do the same without using a plugin.
If I understand it right, this PR is now obsolete, as we're covered by the default browser player.
Thank you @eyvazahmadzada for your contribution. If I'm wrong, please ping me to reopen.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-05 12:23:26 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
NPM Resource Changed
?
|
||
I have tested this item✅ successfully on 0cf67aa
Really nice UX improvement.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35177.