? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
17 Aug 2021

Pull Request for Issue # .

Summary of Changes

Fix the SQL update statement from PR #35164 for certain older MySQL or MariaDB versions.

Use (almost) the same changes also for PostgreSQL because it's better SQL.

CROSS JOIN is supported on MySQL 5.6. so it is ok for Joomla 4.

On PostgreSQL it is supported too, but not in UPDATE statements, it seems, therefore the slightly different syntax for PostgreSQL.

Testing Instructions

  1. Update from 3.10 to 4.0 using a new package which includes the merged PR #35164 .
    You can build a package with following command:
    php ./build/build.php --remote=HEAD --exclude-gzip --exclude-bzip2
    Result: See section "Actual result BEFORE applying this Pull Request" below.

  2. Do the same again but use the update package built by drone for this PR.
    Result: See section "Expected result AFTER applying this Pull Request" below.

Actual result BEFORE applying this Pull Request

On certain older MySQL (5.7 in my case) or MariaDB versions:

2021-08-17_j4-update-sql-error

On newer versions of MySQL or MariaDB and on PostgreSQL there is no such error.

Expected result AFTER applying this Pull Request

No such SQL error on any supported database version.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 17 Aug 2021
avatar richard67 richard67 - change - 17 Aug 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2021
Category SQL Administration com_admin Postgresql
avatar richard67 richard67 - change - 17 Aug 2021
The description was changed
avatar richard67 richard67 - edited - 17 Aug 2021
avatar richard67 richard67 - change - 17 Aug 2021
The description was changed
avatar richard67 richard67 - edited - 17 Aug 2021
avatar richard67
richard67 - comment - 17 Aug 2021

System tests are broken due to merged PR #35168 in the 40-dev branch.

avatar HLeithner
HLeithner - comment - 17 Aug 2021

Working for version 5.6.40-84.0

avatar richard67 richard67 - change - 17 Aug 2021
Labels Added: ? ?
avatar zero-24
zero-24 - comment - 17 Aug 2021

Works ok on 10.4.13-MariaDB

avatar richard67 richard67 - change - 17 Aug 2021
Title
[WiP] Use cross join and combine update statements for package_id
Combine update statements for package_id of search extensions
avatar richard67 richard67 - edited - 17 Aug 2021
avatar richard67 richard67 - change - 17 Aug 2021
The description was changed
avatar richard67 richard67 - edited - 17 Aug 2021
avatar HLeithner HLeithner - change - 17 Aug 2021
Labels Added: ? ?
Removed: ? ?
avatar richard67 richard67 - change - 17 Aug 2021
The description was changed
avatar richard67 richard67 - edited - 17 Aug 2021
avatar HLeithner HLeithner - change - 17 Aug 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-08-17 10:44:02
Closed_By HLeithner
avatar HLeithner HLeithner - close - 17 Aug 2021
avatar HLeithner HLeithner - merge - 17 Aug 2021
avatar HLeithner
HLeithner - comment - 17 Aug 2021

Thanks @richard67 and @zero-24

avatar zero-24
zero-24 - comment - 17 Aug 2021

Thanks @richard67

avatar richard67 richard67 - change - 24 Aug 2021
The description was changed
avatar richard67 richard67 - edited - 24 Aug 2021

Add a Comment

Login with GitHub to post a comment