Feeling Lucky
Language Change
?
[#35067] - [4.0] [WiP] Delete folders on update only if they are empty
- Closed
- 8 Aug 2021
- Medium
- Build: 4.0-dev
- Draft PR
- # 35067
- Diff
- richard67:4.0-dev-delete-folders-on-update-only-if-empty
User tests: Successful: Unsuccessful:
Pull Request for Issue #34298 .
Summary of Changes
Work in Progress (WiP)
Change function "deleteUnexistingFiles" in the CMS installer script "administrator/components/com_admin/script.php" so that folders are only attempted to be deleted if they are empty when updating the CMS.
Testing Instructions
Will be added soon.
Actual result BEFORE applying this Pull Request
Will be added soon.
Expected result AFTER applying this Pull Request
Will be added soon.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin Language & Strings Libraries |
| Labels |
Added:
?
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-08 11:11:59 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
Language Change
?
Removed: ? ? |
||
I close this because it contains some mistakes and is not complete yet, and to me it is questionable if we really should go that way.
Just imagine someone browses the Joomla root and then subfolders on Windows with the filesystem explorer or other tools. For every folder which contains an image, a thumbnail file might be created depending on the tool and its settings.
There might be other scenarios where files are created by tools, e.g. if someone uses tools for remote folder synchronization which create hidden files.
These files would block deletion of their parent folders, and these then for their parent folder and so on.
I don't really think that people will check their update log and notice that.