Feeling Lucky
?
Language Change
[#35066] - [3.x] [WiP] Delete folders on update only if they are empty
- Closed
- 8 Aug 2021
- Medium
- Build: staging
- Draft PR
- # 35066
- Diff
- richard67:staging-delete-folders-on-update-only-if-empty
User tests: Successful: Unsuccessful:
Pull Request for Issue #34298 .
Summary of Changes
Work in Progress (WiP)
Change function "deleteUnexistingFiles" in the CMS installer script "administrator/components/com_admin/script.php" so that folders are only attempted to be deleted if they are empty when updating the CMS.
Testing Instructions
Will be added soon.
Actual result BEFORE applying this Pull Request
Will be added soon.
Expected result AFTER applying this Pull Request
Will be added soon.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin Language & Strings Libraries |
| Title |
|
||||||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-08 10:07:39 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
Language Change
|
||
Sorry for having wasted your time.
This PR is incomplete or even wrong as it is, and I don't even think that the files and folder deletion should be changed in CMS version 3, because in opposite to version 4 it might be (I haven't checked that) that the list of files and folders to be deleted contains only a parent folder but not subfolders and files in some case.
Let's continue discussion in the issue.