? NPM Resource Changed Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
6 Aug 2021

Summary of Changes

Removes an very old CSS which makes no sense but kills correct bootstrap dropdown. Corrects alignment.

Actual result BEFORE applying this Pull Request

grafik

grafik

Expected result AFTER applying this Pull Request

grafik

grafik

avatar bembelimen bembelimen - open - 6 Aug 2021
avatar bembelimen bembelimen - change - 6 Aug 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Aug 2021
Category Front End Templates (site) NPM Change
avatar brianteeman
brianteeman - comment - 6 Aug 2021

Kind of hard to test as its not reproducible with the core template. IIRC those items with the indent are Menu-Item Separators? The PR does make sense though and it shouldnt impact anything else on the frontend

avatar bembelimen
bembelimen - comment - 6 Aug 2021

Kind of hard to test as its not reproducible with the core template. IIRC those items with the indent are Menu-Item Separators? The PR does make sense though and it shouldnt impact anything else on the frontend

Yes that's the problem. Probably creating a com_custom module with the following entries:

<ul id="nav-joomla" class="nav">
	<li class="dropdown nav-item">
		<a class="dropdown-toggle nav-link" data-toggle="dropdown" href="#">
			<span dir="ltr"><span aria-hidden="true" class="icon-joomla"></span> Joomla!<sup>&reg;</sup></span>
		</a>
		<ul class="dropdown-menu">
			<li class="dropdown-header"><span>About us</span></li>
			<li>
				<a class="dropdown-item" href="https://www.joomla.org">
					<span aria-hidden="true" class="icon-joomla"></span> Joomla Home
				</a>
			</li>
			<li><a class="dropdown-item" href="https://www.joomla.org/about-joomla.html">What is Joomla?</a></li>
			<li><a class="dropdown-item" href="https://www.joomla.org/core-features.html">Benefits &amp; Features</a></li>
			<li><a class="dropdown-item" href="https://www.joomla.org/about-joomla/the-project.html">Project &amp; Leadership</a></li>
			<li><a class="dropdown-item" href="https://tm.joomla.org">Trademark &amp; Licensing</a></li>
			<li><a class="dropdown-item" href="https://joomlafoundation.org">The Joomla Foundation</a></li>
			<li class="divider"></li>
			<li class="dropdown-header"><span>Support us</span></li>
			<li><a class="dropdown-item" href="https://www.joomla.org/contribute-to-joomla.html">Contribute</a></li>
			<li><a class="dropdown-item" href="https://www.joomla.org/sponsor.html">Sponsor</a></li>
			<li><a class="dropdown-item" href="https://www.joomla.org/about-joomla/partners.html">Partner</a></li>
			<li><a class="dropdown-item" href="https://shop.joomla.org">Shop</a></li>
		</ul>
	</li>
	<li class="dropdown nav-item">
		<a class="dropdown-toggle nav-link" data-toggle="dropdown" href="#">Download &amp; Extend</a>
		<ul class="dropdown-menu">
			<li><a class="dropdown-item" href="https://downloads.joomla.org">Downloads</a></li>
			<li><a class="dropdown-item" href="https://extensions.joomla.org">Extensions</a></li>
			<li><a class="dropdown-item" href="https://community.joomla.org/translations.html">Languages</a></li>
			<li><a class="dropdown-item" href="https://launch.joomla.org">Get a free site</a></li>
			<li><a class="dropdown-item" href="https://domains.joomla.org">Get a domain</a></li>
		</ul>
	</li>
	<li class="dropdown nav-item">
		<a class="dropdown-toggle nav-link" data-toggle="dropdown" href="#">Discover &amp; Learn</a>
		<ul class="dropdown-menu">
			<li><a class="dropdown-item" href="https://docs.joomla.org">Documentation</a></li>
			<li><a class="dropdown-item" href="https://community.joomla.org/joomla-training.html">Training</a></li>
			<li><a class="dropdown-item" href="https://certification.joomla.org">Certification</a></li>
			<li><a class="dropdown-item" href="https://showcase.joomla.org">Site Showcase</a></li>
			<li><a class="dropdown-item" href="https://www.joomla.org/announcements.html">Announcements</a></li>
			<li><a class="dropdown-item" href="https://community.joomla.org/blogs.html">Blogs</a></li>
			<li><a class="dropdown-item" href="https://magazine.joomla.org">Magazine</a></li>
		</ul>
	</li>
	<li class="dropdown nav-item">
		<a class="dropdown-toggle nav-link" data-toggle="dropdown" href="#">Community &amp; Support</a>
		<ul class="dropdown-menu">
			<li><a class="dropdown-item" href="https://community.joomla.org">Community Portal</a></li>
			<li><a class="dropdown-item" href="https://community.joomla.org/events.html">Events</a></li>
			<li><a class="dropdown-item" href="https://community.joomla.org/user-groups.html">User Groups</a></li>
			<li><a class="dropdown-item" href="https://forum.joomla.org">Forum</a></li>
			<li><a class="dropdown-item" href="https://community.joomla.org/service-providers-directory.html">Service Providers Directory</a></li>
			<li><a class="dropdown-item" href="https://volunteers.joomla.org">Volunteers Portal</a></li>
			<li><a class="dropdown-item" href="https://extensions.joomla.org/vulnerable-extensions/vulnerable/">Vulnerable Extensions List</a></li>
		</ul>
	</li>
	<li class="dropdown nav-item">
		<a class="dropdown-toggle nav-link" data-toggle="dropdown" href="#">Developer Resources</a>
		<ul class="dropdown-menu">
			<li><a class="dropdown-item" href="https://developer.joomla.org">Developer Network</a></li>
			<li><a class="dropdown-item" href="https://developer.joomla.org/security.html">Security Centre</a></li>
			<li><a class="dropdown-item" href="https://issues.joomla.org">Issue Tracker</a></li>
			<li><a class="dropdown-item" href="https://github.com/joomla">GitHub</a></li>
			<li><a class="dropdown-item" href="https://api.joomla.org">API Documentation</a></li>
			<li><a class="dropdown-item" href="https://framework.joomla.org"><span dir="ltr">Joomla!</span> Framework</a></li>
		</ul>
	</li>
</ul>
avatar brianteeman
brianteeman - comment - 6 Aug 2021

The problem with that is that bootstrap dropdown menus don't work in cassiopeia

avatar wilsonge wilsonge - change - 7 Aug 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-08-07 19:24:39
Closed_By wilsonge
Labels Added: ? NPM Resource Changed
avatar wilsonge wilsonge - close - 7 Aug 2021
avatar wilsonge wilsonge - merge - 7 Aug 2021
avatar wilsonge
wilsonge - comment - 7 Aug 2021

I'm going to merge this on review as this has been tested on the J4 landing page template development work and shouldn't impact casseopia as mentioned as we don't use these menus

Add a Comment

Login with GitHub to post a comment