@drmenzelit @hans2103 @dgrammatiko @richard67 please review / test.

@RickR2H can you move the fix for scroll-to-top to another PR or adjust the description and title of this PR?
You're changing more than you describe.

@hans2103 All changes are connected, so I changed the title and description.

please adjust the following:

templates/cassiopeia/scss/blocks/_back-to-top.scss
7:3  ✖  Expected "position" to come before "opacity"     order/properties-order
9:3  ✖  Expected "right" to come before "bottom"         order/properties-order
17:3  ✖  Expected "z-index" to come before "transition"   order/properties-order

that's why the build fails

@RickR2H Regarding your review request: I think I'm not the right guy to review since my knowledge on CSS and JS is too little.

please adjust the following:

templates/cassiopeia/scss/blocks/_back-to-top.scss
7:3  ✖  Expected "position" to come before "opacity"     order/properties-order
9:3  ✖  Expected "right" to come before "bottom"         order/properties-order
17:3  ✖  Expected "z-index" to come before "transition"   order/properties-order

that's why the build fails

Thanks Hans. Pushed new commit

Just wanted to post but Hans was faster.

@RickR2H onwards to solve the next check.

	templates/cassiopeia/scss/blocks/_back-to-top.scss
8	  8:3  ✖  Expected "right" to come before "opacity"           order/properties-order
9	 16:3  ✖  Expected "z-index" to come before "border-radius"   order/properties-order

note... if you only move right, the next build will fail because bottom needs to be before opacity too.
You might consider using scss code styling check in your IDE.

@RickR2H You can use following commands to check code style on the command line if you have npm:

npm run lint:css

npm run lint:js

npm run lint:css

Thanks Richard! I'll do that next time!

@RickR2H I see a lot of spacing added... is that correct?
https://github.com/joomla/joomla-cms/pull/35012/files

Mmmm that's look like something is, wrong with the indentation. I'll try to fix today.

@hans2103 Did a review of the whole index.php to make indentation more structured. To review the indentations, please take a look at the whole file instead of looking at only the changes in Git. Hope these changes are more appealing to the eye ?

Something still not correct

https://github.com/joomla/joomla-cms/blob/78f11a01f2fb09bb0b534e54476f2e452556bd1b/templates/cassiopeia/index.php

@brianteeman @hans2103 Is it a better option to remove the empty lines?

please review https://github.com/joomla/joomla-cms/blob/d374cbdb98bdca5e6869d6120c8140d6e34f9a62/templates/cassiopeia/index.php

@RickR2H please remove the .gz file

I have tested this item ✅ successfully on daf07c2

I have tested this item ✅ successfully on daf07c2

Tested with and without content, with and without back-to-top, with and without modules on the sidebar, in rtl and in different display sizes.

The case with very short content and some modules in bottom positions is a very edge case I guess, so I can live with bottom modules not being at the very bottom of the page ;-)

Thank you @RickR2H for your work.

@drmenzelit @hans2103 thanks for testing

RTC

@wilsonge dm on Glip

@wilsonge Ive tested and this works and fixes #35119. LGTM :)

Actually... while this fixes the immediate issue of #35119 enough to launch Joomla 4, the 404/403 error page is screwed up and the footer appears above the content

I have tested this item ✅ successfully on daf07c2

Further tests on this and still its working fine

Further tests on this and still its working fine

Except its not though. Test the error page. The 404 page. The 403 error page.

@PhilETaylor I can check if this can be fixed really quickly...

also if you have a named link fragment like

<a href="#top"......

but there is no named anchor html element with a name of top, is that even valid? Probably valid HTML but still not perfect right?

Yes i know JS is doing the "actual" window.scrollTo but there should be a named anchor for completeness right?

Also - is it meant to smooth scroll still? because it doesnt, it jumps instantly when clicked.

Also - is it meant to smooth scroll still? because it doesnt, it jumps instantly when clicked.

Ignore that - Safari on mac doesnt like smooth scroll apparently. Works in google chrome... yet another difference with Joomla and Safari :(

@PhilETaylor the error page is fixed...

Problem now is that is need two tests to pass

@RickR2H Could you update your testing instructions by adding a short hint to check also the error page? Thanks in advance.

@PhilETaylor the error page is fixed...

Yes I can confirm its working for me too now - thanks for quickly fixing this. Ive not comprehensively tested the rest of the PR, apart from it fixes my reported issue in #35119 and now fixes the error page too.

@richard67 @wilsonge Im happy if you are, the other tests are valid still I think because the changes only changed the error.php files.

@PhilETaylor If you mark your test result in the issue tracker here https://issues.joomla.org/tracker/joomla-cms/35012 and @softforge or one of the other previous testers is available to test again, that would be fine.

I have tested this item ✅ successfully on ec7881f

Updated the test instructions as mentioned

@richard67 we still need one more test to pass ?

I have tested this item ✅ successfully on ec7881f

Had server errors on. Switched off and could confirm Phil T issue. Updated to the latest build and confirm the footer switched position to the correct position on 404 and 403.

Thanks!

Has anyone tested RTL?

I am just testing, too, and just wanted to.

Has anyone tested RTL?

I cant even spell my name backward. So no.

Will check now...

RTL looked ok here, the rest too.

I've noticed that the error page doesn't respect the "Sticky Header" option of the template style settings, but that might also have been the case without this PR. am just checking that.

Yes, was also case before this PR. So I have not found any issues, all ok.

Now let's hope nobody of us missed anything ;-)

@richard67 RTL works! Also tested the error page. Thanks to all!