[#35001] - [4.0] Added php8 to list of filtered extensions
- Fixed in Code Base
- 4 Aug 2021
- Medium
- Build: 4.0-dev
- # 35001
- Diff
- SniperSister:4x-php8filter
User tests: Successful: Unsuccessful:
Summary of Changes
Added PHP8 to the hardcoded list of executables
Testing Instructions
Verify by code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
?
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.
@SniperSister It's not sufficient to set the RTC label on GitHub to get the right status shown in the issue tracker. It needs to use the tracker and change status there. I've done that here now.
I have not tested this item.
reverting my successful test
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.
#34999 blocks .php
#35001 blocks .php, .php3, .php4, .php5, .php6, .php7, .php8I don't see the logic behind this difference
@brianteeman Me neither ... but that's the other way round. You had complained the list here in #35001 is shorter than the other one in #34999 .
=> Ping @SniperSister : Should be add .php3, .php4, .php5, .php6, .php7, .php8 and possibly others to #34999 , too?
@brianteeman Me neither ... but that's the other way round. You had complained the list here in #35001 is shorter than the other one in #34999 .
Because the entire list is shorter ;)
Just this part is longer
Because the entire list is shorter ;)
@brianteeman About this aspect see my comment above #35001 (comment) .
i disagree completely with that comment - its either secure or not. its not dependant on where it is used.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.
I have tested this item
The reasoning behind this list makes it incomplete
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.
@brianteeman @richard67 This PR is set as Release Blocker... But is this really the case?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-04 21:54:06 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 4d73fbc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35001.