? Pending

User tests: Successful: Unsuccessful:

avatar SniperSister
SniperSister
31 Jul 2021

Summary of Changes

Added PHP8 to the hardcoded list of executables

Testing Instructions

Verify by code review

avatar SniperSister SniperSister - open - 31 Jul 2021
avatar SniperSister SniperSister - change - 31 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jul 2021
Category Libraries
avatar richard67 richard67 - change - 31 Jul 2021
Title
[3.10] Added php8 to list of forbidden executable extensions
Added php8 to list of forbidden executable extensions
avatar richard67 richard67 - edited - 31 Jul 2021
avatar richard67
richard67 - comment - 31 Jul 2021

As it's for staging I've removed the "[3.10]" from the title.

avatar richard67 richard67 - test_item - 31 Jul 2021 - Tested successfully
avatar richard67
richard67 - comment - 31 Jul 2021

I have tested this item successfully on 595e238

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35000.

avatar brianteeman brianteeman - test_item - 31 Jul 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 31 Jul 2021

I have tested this item successfully on 595e238


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35000.

avatar richard67 richard67 - change - 31 Jul 2021
Status Pending Ready to Commit
Labels Added: ? ?
avatar richard67
richard67 - comment - 31 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35000.

avatar richard67
richard67 - comment - 31 Jul 2021

@SniperSister It's not sufficient to set the RTC label on GitHub to get the right status shown in the issue tracker. It needs to use the tracker and change status there. I've done that here now.

avatar richard67
richard67 - comment - 31 Jul 2021

Drone failing for unrelated reasons ... restarted to see if it succeeds this time.

avatar brianteeman brianteeman - test_item - 31 Jul 2021 - Not tested
avatar brianteeman
brianteeman - comment - 31 Jul 2021

I have not tested this item.

reverting my successful test


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35000.

avatar richard67 richard67 - change - 31 Jul 2021
Status Ready to Commit Pending
avatar richard67
richard67 - comment - 31 Jul 2021

Back to pending.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35000.

avatar RickR2H RickR2H - test_item - 2 Aug 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 2 Aug 2021

I have tested this item successfully on 595e238


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35000.

avatar richard67 richard67 - change - 2 Aug 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 2 Aug 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35000.

avatar brianteeman brianteeman - test_item - 2 Aug 2021 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 2 Aug 2021

I have tested this item ? unsuccessfully on 595e238

The reasoning behind this list makes it incomplete


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35000.

avatar richard67 richard67 - change - 2 Aug 2021
Status Ready to Commit Pending
avatar richard67
richard67 - comment - 2 Aug 2021

Back to pending.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35000.

avatar zero-24
zero-24 - comment - 8 Aug 2021

Merging to sync up with 4.0: #35001 Thanks!

avatar zero-24 zero-24 - change - 8 Aug 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-08-08 18:10:21
Closed_By zero-24
Labels Added: ?
Removed: ? ?
avatar zero-24 zero-24 - close - 8 Aug 2021
avatar zero-24 zero-24 - merge - 8 Aug 2021

Add a Comment

Login with GitHub to post a comment